Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docstring for make_dataset is incomplete #121

Open
musoke opened this issue May 10, 2023 · 0 comments
Open

docstring for make_dataset is incomplete #121

musoke opened this issue May 10, 2023 · 0 comments

Comments

@musoke
Copy link
Contributor

musoke commented May 10, 2023

def make_dataset(config, dataset=None, save_to_disk=False, store_in_memory=True,
verbose=False, store_sample=False, image_file_format='npy',
survey=None, return_planes=False, skip_image_generation=False,
solve_lens_equation=False):
"""
Generate a dataset from a config file.
Args:
config (str or dict): name of yaml file specifying dataset characteristics or pre-parsed yaml file as dictionary
verbose (bool, optional, default=False): print progress and status updates at runtime
store_in_memory (bool, optional, default=True): save images and metadata as attributes
save_to_disk (bool, optional, default=False): save images and metadata to disk
store_sample (bool, optional, default=False): save five images and metadata as attribute
image_file_format (str, optional, default='npy'): outfile format type, options include ('npy', 'h5')
survey (str or None, optional, default=None): a default astronomical survey to use
return_planes (bool, optional, default=False): return the lens, source, noise, and point source planes of the simulated images
skip_image_generation (bool, optional, default=False): skip image generation
solve_lens_equation (bool, optional, default=False): calculate the source positions
Returns:
dataset (Dataset): and instance of the Dataset class
Raises:
RuntimeError: If `skip_image_generation == True` and `solve_lens_equation == True`
RuntimeError: If `survey` is not a valid survey name
"""

does not indicate the significance of param dataset or its expected type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants