Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api changes from >=1.14 break demo #19

Open
wiesbadener opened this issue Jun 28, 2023 · 1 comment
Open

Api changes from >=1.14 break demo #19

wiesbadener opened this issue Jun 28, 2023 · 1 comment

Comments

@wiesbadener
Copy link

wiesbadener commented Jun 28, 2023

Api changes from >=1.14 are reflected in explore_the_world/ui/utils.py --> query function. With these changes there now is a check for answers "document_ids" that value did not exist <1.14.

However, the haystack-api image: "deepset/haystack:cpu" was not updated in the last six months. Hence, the explore_the_world demo is still using API version 1.12. Resulting in a bug.

Suggesting to change image in docker compose file:

haystack-api:
    image: "deepset/haystack:cpu-main"

Same for explore_the_world/deploy/docker-compose.prod.yml ( currently image: "deepset/haystack:gpu-v1.12.2" )

@bilgeyucel
Copy link
Contributor

Hi @wiesbadener 👋 thank you for opening the issue, this is a great catch! 🚀 If you're interested in contributing, feel free to open a PR to the repo. If not, no worries, we'll fix this for sure 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants