-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update AmazonBedrockChatGenerator to use Converse API #1219
base: main
Are you sure you want to change the base?
Conversation
@julian-risch @silvanocerza do you remember who was giving us permissions for Amazon Bedrock models, was it @askainet ? We need to ping him to click through all these Amazon Bedrock models in this PR so they become available on our Haystack account... |
|
||
# so far we've discovered these models support streaming and tool use | ||
STREAMING_TOOL_MODELS = ["anthropic.claude-3-5-sonnet-20240620-v1:0", "cohere.command-r-plus-v1:0"] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These models in MODELS_TO_TEST, MODELS_TO_TEST_WITH_TOOLS and STREAMING_TOOL_MODELS @askainet 🙏 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paul set us up 🚀
@anakin87 would you please give it a rough pass first to make sure I'm not forgetting any major parts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a cursory look and I like the change and the approach, also because we are deleting a lot of code :-)
Ping me when you need a more in-depth review.
Enhances the integration with Amazon Bedrock by using the new Converse API in
AmazonBedrockChatGenerator
. The modifications address the removal of outdated adapter structures and simplifies code greatly all while maintaining compatibility as much as possible.What:
adapters.py
file was deleted to eliminate deprecated structures related to chat model adapters.chat_generator.py
:test_chat_generator.py
to include new model tests and validate functionality with the new configurations and expected responses.How can it be used:
How did you test it:
Conducted integration tests that focused on:
AmazonBedrockChatGenerator
with various model configurations.Notes for the reviewer:
adapters.py
file to understand how changes in architecture affect existing functionalities.