-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: few shots should support image input #155
Comments
I believe "FewShotExample type should be extended with optional field representing list of input images" is not necessary. So we only need to make sure that the existing API for providing few show examples works as expected:
Currently |
This is complicated. I think it would be good to discuss during grooming what kind of data should Prompt's
At the beginning of the project we discussed between 1 and 2 and decided to go with 1. Adding images showed some disadvantages of 1 (prompt alone cannot know what the particular LLM model can handle). Currently (with the latest PR adding images to prompt and with how this ticket is written) we seem to be going the route of 3. I'm not convinced it's the best route - it seems quite wobbly (for example: knowing which image to add to which element of the conversation). I'm not convinced it's the best route - I think it would be worth revisiting our previous discussion as the team. |
@mhordynski I believe you wanted to read through the comments here and decide on one of the options |
Feature description
Action items:
FewShotExample
type should be extended with optional field representing list of input imageslist_few_shots
of classPrompt
should be able to recognize whether the given few shot entry contains imageslist_few_shots
should be moved toLLM
method:_format_chat_for_llm
because of deciding whether the given model supports visionMotivation
Users would need to create few shot learning systems for image processing - eg. classification etc.
Additional context
No response
The text was updated successfully, but these errors were encountered: