rm old files when performing dp model-devi
#1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dp model-devi` appends output into the existing file instead of overwriting it, so if there is an existing file (maybe caused by restart), there might be errors in reading it. `rm -f` does not check if the file exists and always returns exit code 0. Signed-off-by: Jinzhe Zeng <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #1332 +/- ##
=======================================
Coverage 48.54% 48.54%
=======================================
Files 82 82
Lines 14659 14659
=======================================
Hits 7116 7116
Misses 7543 7543
☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dp model-deviappends output into the existing file instead of overwriting it, so if there is an existing file (maybe caused by restart), there might be errors in reading it.rm -fdoes not check if the file exists and always returns exit code 0.