Allow scratch name to be highlighted and copied for non-owners #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkst
reviewed
Oct 9, 2024
| @@ -115,7 +115,7 @@ function ScratchName({ name, onChange }: { name: string, onChange?: (name: strin | |||
| /> | |||
| } else { | |||
| return <div | |||
| className={classNames(styles.name, { [styles.editable]: !!onChange })} | |||
| className={classNames(styles.name, styles.scratchName, { [styles.editable]: !!onChange })} | |||
There was a problem hiding this comment.
Would it make more sense to add these css attributes to the .name class instead? and then make cursor: text; the default rather than only when &.editable ?
|
Great stuff! |
mkst
pushed a commit
that referenced
this pull request
Oct 11, 2024
* Add scratchName class to allow highlighting and copying the scratch name * Use .name to allow selecting scratch name
mkst
pushed a commit
that referenced
this pull request
Oct 27, 2024
* Implement ASM Diff contents Copy Button (#1357) * Implement diff copy button * Make vercel deployment happy * Make vercel deployment happier * Just remove the alert * Tweak styles * Retrigger deployments * Lazy loaded and refactored CopyButton component logic * Allow scratch name to be highlighted and copied for non-owners (#1359) * Add scratchName class to allow highlighting and copying the scratch name * Use .name to allow selecting scratch name * Properly center the copy button icon --------- Co-authored-by: PerikiyoXD <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
ScratchToolbarcomponent to improve the user experience by allowing the scratch name to be highlighted and copied.Improvements to user experience:
frontend/src/components/Scratch/ScratchToolbar.module.scss: Added a new CSS class.scratchNameto enable text selection and cursor indication for the scratch name.frontend/src/components/Scratch/ScratchToolbar.tsx: Updated theScratchNamecomponent to use the new.scratchNameclass, allowing the scratch name to be highlighted and copied.Fixes #1354