Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send PATCH request when (confirm edit) pressed if the message wasn't actually edited #310

Open
towerofnix opened this issue May 5, 2018 · 0 comments
Labels
client Affects the @decent/client package.

Comments

@towerofnix
Copy link
Member

If you click on the edit button and don't actually change the text in the message, the PATCH request to edit the message shouldn't be sent (since it wouldn't change anything).

The implementation for this should keep track of the value before being edited and only send the request if the value, when the confirm edit button is pressed, is different from the original value. The original value should be scrapped afterwords (once a message edit is finalized, the original value shouldn't be remembered).

@towerofnix towerofnix added the client Affects the @decent/client package. label May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Affects the @decent/client package.
Projects
None yet
Development

No branches or pull requests

1 participant