Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using Libravatar #305

Open
kerrtravers opened this issue Apr 6, 2018 · 4 comments
Open

Stop using Libravatar #305

kerrtravers opened this issue Apr 6, 2018 · 4 comments
Labels
has impl A PR/branch exists to resolve this - we don't recommend re-tackling it.

Comments

@kerrtravers
Copy link

Libravatar is shutting down on 2018-09-01(blog post). We'll need to stop using it soon, and prepare to switch to something else as the main source of Avatars. I'm guessing it'll be Gravatar.

@towerofnix
Copy link
Member

@ktrvs Thanks for bringing this up!

@heyitsmeuralex Thoughts on being able to directly upload avatars to the Decent server? Assuming users are allowed to upload images, anyhow. See also #101.

Since we probably won't get that done for a very, very, very long time (it's dependent on the permission system!), I recommend changing the code to fetch from Gravatar instead of Libravatar. (Note this is a server-side change - there's a function (in server/common.js) called emailToAvatarURL that should be updated.)

@towerofnix towerofnix added help wanted If you're good at this, we need your help server Affects the @decent/server package. labels Apr 6, 2018
@towerofnix
Copy link
Member

Of course, the relevant message in the client should be changed as well ("We use Gravatar..." instead of "We use Libravatar...").

@towerofnix towerofnix removed the server Affects the @decent/server package. label Apr 6, 2018
@bates64
Copy link
Collaborator

bates64 commented Apr 7, 2018

RIP.

Directly uploading images should be a server option, but yeah. Speaking of, how is the permission system going @towerofnix? I know there's been a lack of commits the past couple weeks but once we get past that point it should be smooth sailing to 1.0.

@towerofnix
Copy link
Member

@heyitsmeuralex Given I don't use any chat systems frequently anymore (I'm mostly lurking the main chats!), I haven't been doing much work on Decent; I've been occupied doing a lot of other stuff, which definitely includes school and sleep! :P

@bates64 bates64 added the has impl A PR/branch exists to resolve this - we don't recommend re-tackling it. label May 4, 2018
@towerofnix towerofnix removed the help wanted If you're good at this, we need your help label May 5, 2018
@bates64 bates64 mentioned this issue May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has impl A PR/branch exists to resolve this - we don't recommend re-tackling it.
Projects
None yet
Development

No branches or pull requests

3 participants