Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should a user with manageRoles be able to delete roles that contain settings for permissions that the user does not have? #303

Open
towerofnix opened this issue Mar 9, 2018 · 3 comments
Labels
discuss We should discuss this. server Affects the @decent/server package.

Comments

@towerofnix
Copy link
Member

I'm leaning towards "no", but I'd like thoughts.

@towerofnix towerofnix added server Affects the @decent/server package. discuss We should discuss this. labels Mar 9, 2018
@bates64
Copy link
Collaborator

bates64 commented Mar 10, 2018

Is there a 'manageAllRoles' permission, or similar? Otherwise I'd say manageRoles should let you control all manner of roles ie. you're an admin. Not sure how it's currently laid out in the spec though?

@bates64
Copy link
Collaborator

bates64 commented Mar 10, 2018

Side Q - @towerofnix does the spec make the _member and _guest (or whatever their names are) roles obvious enough that they will be implemented by default? We should probably declare a default set of permissions for these default roles (that servers should use at init) and say they may not be renamed or deleted.

@towerofnix
Copy link
Member Author

@heyitsmeuralex Updating the docs to make note of the specific permissions given to default roles would be good. In my branch, I've got a roles.js file that contains all default roles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss We should discuss this. server Affects the @decent/server package.
Projects
None yet
Development

No branches or pull requests

2 participants