Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow servers to provide an icon. #278

Open
PullJosh opened this issue Mar 3, 2018 · 2 comments
Open

Allow servers to provide an icon. #278

PullJosh opened this issue Mar 3, 2018 · 2 comments
Labels
discuss We should discuss this. enhancement BETTER THING!! has impl A PR/branch exists to resolve this - we don't recommend re-tackling it.

Comments

@PullJosh
Copy link
Collaborator

PullJosh commented Mar 3, 2018

Idea from @heyitsmeuralex

Servers should be able to declare a server icon URL at /api/ to be used by the client. The intention (as specified by alex) is to have the client set the page favicon based on the icon, although I could also see it being used elsewhere (maybe in the server dropdown menu?)
@PullJosh PullJosh added enhancement BETTER THING!! discuss We should discuss this. labels Mar 3, 2018
@bates64
Copy link
Collaborator

bates64 commented Mar 3, 2018

maybe in the server dropdown menu?

oh yeah i forgot to mention that

bates64 added a commit that referenced this issue Mar 3, 2018
@bates64
Add serverSettings.iconURL & server setting update event
0bfe65d 
Fixes #278.
@bates64
Copy link
Collaborator

bates64 commented Mar 9, 2018

Note 1.0.0 has this feature; waiting until it's released to close.

@bates64 bates64 added the has impl A PR/branch exists to resolve this - we don't recommend re-tackling it. label Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss We should discuss this. enhancement BETTER THING!! has impl A PR/branch exists to resolve this - we don't recommend re-tackling it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PullJosh @bates64