-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
few issues with decap-cms-app @ 3.5.0 #7375
Comments
@dragons-library Thanks for raising these and providing the workarounds. These will be useful until we come up with a solution. Note that Decap + React 19 is not officially supported yet, so it's great that we can use your suggestions to make it work. |
Just for context, I think the first two are things that "broke" with the 3.5.0 release for anyone that started consuming the esm build of The 4th item is definitely more specific to React 19 support. If I have time over the next week or so, I'll try to put together a PR, but if anyone else has the bandwidth and wants to take a stab at it, the above details should be sufficient. |
Exceptions are: - react: kept at v18 as we still use Gatsby - node types: kept at v20 - we actually use this version - tailwind: it's too early for v4 - hast, unified: I have no clue how to update these monsters - decap: kept at v3.4 as v3.5 is buggy decaporg/decap-cms#7375
Exceptions are: - @types/wordpress__*: we just can't update these - react: kept at v18 as we still use Gatsby - node types: kept at v20 - we actually use this version - tailwind: it's too early for v4 - hast, unified: I have no clue how to update these monsters - decap: kept at v3.4 as v3.5 is buggy decaporg/decap-cms#7375
I just bumped
decap-cms-app @ 3.5.0
(from 3.4.0).After the esm fixes, there are a few lingering things that prevent it from fully functioning.
Note: with the below fixes / workarounds, I have
decap-cms-app
working in Next.js with React 19.1.
can't resolve 'slate-hyperscript'
decap-cms-app
does not declare a dependency / peerDependency onslate-hyperscript
, so it fails to resolve (nested dependency fromdecap-cms-core
).Error
Workaround
Proposed Fix
Adding
slate-hyperscript
todecap-cms-app/package.json#peerDependencies
should probably work, but peerDeps are notoriously problematic.2.
[email protected]
is not browser friendly[email protected]
importsos
, which is a node module (node:os
), and not resolved in browser-land. This was fixed and released in[email protected]
.Error
Workaround
add a local override to bump
[email protected]
to yourpackage.json
:Proposed Fix
bump
clean-stack@^5.2.0
indecap-cms-core
3. Next.js app fails to resolve css
ol/ol.css
codemirror/lib/codemirror.css
codemirror/theme/material.css
Error (with turbopack)
Error (without turbopack):
Workaround
patch-package
and remove the css imports from the packages (see attachments), and manually import them directly in my app:Workaround
The esm build output should probably inline the CSS, as there isn't an industry standard for resolving css imports.
4.
[email protected]
is not compatible with React 19This isn't specifically related to the esm build changes, but this should help fix React compatibility issues. The current version of
react-scroll-sync
is not compatible with React 19.Error
Workaround
add a local override to bump
[email protected]
to yourpackage.json
:Proposed Fix
bump
react-scroll-sync@^0.11.2
indecap-cms-core
The text was updated successfully, but these errors were encountered: