Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big gap between the file name and the text #35

Open
flowing-abyss opened this issue Oct 13, 2022 · 5 comments
Open

Big gap between the file name and the text #35

flowing-abyss opened this issue Oct 13, 2022 · 5 comments

Comments

@flowing-abyss
Copy link

There is a big gap between the file name and the text.
This appeared on version 1.0.
2022-10-13_22-01_1

ftvkyo added a commit to ftvkyo/cm-typewriter-scroll-obsidian that referenced this issue Oct 30, 2022
@drventure
Copy link

Was going to add a feature request but looks like it's already here.

Basically, what I'd suggest is 2 new options.

  1. enable/disable scrolling to center at the top
  2. enable/disable scrolling to center at the bottom

Essentially, if enabled, it would continue to work as you have it.
if disabled, once the cursor got to within (height/2) lines from the top, scrolling would stop and the cursor would simply move up to the topline without all the extra space.

Same thing at the bottom.

And of course, if the note wasn't even a full screen of lines, then no scrolling at all.

@yarub123
Copy link

Same issue here:
image

@davisriedel
Copy link

I created a new plugin based on this one, which has many new features. I also fixed this issue. You can check it out here. The plugin is currently in beta. At first I wanted to post a PR to this plugin, but because I had to completely rewrite most parts (to make the new features possible), I decided to turn it into a new plugin, as discussed in #44.

@yarub123
Copy link

@davisriedel Awesome. Sorry to hear you had to rewrite it all man 😬. Nonetheless, it is a learning experience and you gained new workarounds now. Thanks for updating us. This is a beautiful plugin. Appreciate you.

Btw, curious if anyone still has the extra gap still at the top with the beta plugin?

I still have it unfortunately. Not a big deal though, I ended up disabling it for now.

@meljadyn
Copy link

@yarub123 It works for me. I just had to change the setting inside the plugin to enable "Only Maintain Typewriter Offset When Reaches."

I also restarted Obsidian because it didn't immediately take effect for me (though that may be because I hadn't restarted since removing the previous typewriter scroll plugin)

Really appreciate this new plugin by davisriedel, it was my biggest gripe with the typewriter scroll plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants