Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings #11

Open
dkossman opened this issue Oct 2, 2020 · 3 comments
Open

Deprecation warnings #11

dkossman opened this issue Oct 2, 2020 · 3 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@dkossman
Copy link

dkossman commented Oct 2, 2020

sudo npm install -g homebridge-awair-local
npm WARN deprecated [email protected]: request-promise has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: this library is no longer supported
+ [email protected]
added 54 packages from 64 contributors in 70.839s
@dkossman
Copy link
Author

dkossman commented Oct 2, 2020

the plugin seems to be working, but not sure what the impact of these warnings will be in terms of security or reliability.

@deanlyoung
Copy link
Owner

@dkossman thanks for the tip! I will be revisiting this plugin and using the "Platform" (vs. the current "Accessory") method in the near future. It will be based off @DMBlakeley's work on https://github.com/DMBlakeley/homebridge-awair2

@DMBlakeley
Copy link
Collaborator

DMBlakeley commented Oct 7, 2020

@deanlyoung, I am still making use of request and request-promise. Believe they are both in maintenance mode with no additional functionality be added. Did not address as part of "Platform" rewrite. Will look for your recommendation on replacement.

@deanlyoung deanlyoung added the dependencies Pull requests that update a dependency file label Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants