Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lifetimes are problematic for AhoCorasickScratch #5

Open
deadpixi opened this issue Jan 11, 2022 · 0 comments
Open

Lifetimes are problematic for AhoCorasickScratch #5

deadpixi opened this issue Jan 11, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@deadpixi
Copy link
Owner

The way lifetimes are implemented for AhoCorasickScratch make pushing bytes slightly problematic, requiring copies in some situations where they wouldn't otherwise be needed.

Might need to just go back to the callback-based push-AC, which didn't have these problems but was less elegant.
@deadpixi deadpixi added the bug Something isn't working label Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@deadpixi