Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

Tests for scraper #212

Open
ribhav99 opened this issue Apr 8, 2020 · 11 comments
Open

Tests for scraper #212

ribhav99 opened this issue Apr 8, 2020 · 11 comments
Assignees

Comments

@ribhav99
Copy link
Contributor

ribhav99 commented Apr 8, 2020

Add tests for the js scraper

@ribhav99 ribhav99 self-assigned this Apr 8, 2020
@RyanMarten
Copy link
Contributor

@RyanMarten
Copy link
Contributor

need to generate coverage report

@RyanMarten
Copy link
Contributor

uses mocha

@RyanMarten
Copy link
Contributor

make sure to generate a coverage report (may not be the right link https://istanbul.js.org/docs/tutorials/mocha/) but you need to configure the reporter

@RyanMarten
Copy link
Contributor

@RyanMarten
Copy link
Contributor

https://github.com/dcsil/dream-team/blob/master/app/package.json#L66-L70

This is how I configure jest (you will be using mocha not jest)

@RyanMarten
Copy link
Contributor

https://github.com/dcsil/dream-team/blob/master/app/package.json#L30-L35

This is where the npm commands are created. I added the "test-once" command. Do something similar

@jollyredflames
Copy link
Contributor

This is not happenning rn!

@jollyredflames
Copy link
Contributor

Lets fix coverage before doing pull requests in the future

@jollyredflames
Copy link
Contributor

Also, don't merge PR till atleast one person looks at it to simulate a proper flow

@ribhav99
Copy link
Contributor Author

Yeah spoke to ryan when it happened dw

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants