Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullPointerException for changelog of github project without API key define. #243

Open
flesire opened this issue Oct 16, 2013 · 3 comments
Assignees
Labels

Comments

@flesire
Copy link
Contributor

flesire commented Oct 16, 2013

No description provided.

@ghost ghost assigned dcoraboeuf Oct 16, 2013
@dcoraboeuf
Copy link
Owner

  1. I create a new ontrack project
  2. I define only the GitHub project property (to dcoraboeuf/ontrack)
  3. I create the 1.x branch (with no parameter - master is the default)
  4. I import the builds (no parameter)
  5. I select a change log

... and get no NPE...

Can you test the scenario above or tell me the differences with what you have? And attach any stack trace you find.

FYI, the code that relies on the API token is at net.ontrack.extension.github.client.DefaultGitHubClientConfiguratorFactory.

The API token is needed only if you know you will have many many accesses to the change log.

@flesire
Copy link
Contributor Author

flesire commented Oct 17, 2013

java.lang.NullPointerException
    at org.eclipse.jgit.lib.ObjectIdOwnerMap.get(ObjectIdOwnerMap.java:131)
    at org.eclipse.jgit.revwalk.RevWalk.lookupCommit(RevWalk.java:634)
    at org.eclipse.jgit.api.LogCommand.add(LogCommand.java:297)
    at org.eclipse.jgit.api.LogCommand.add(LogCommand.java:172)
    at net.ontrack.extension.git.client.impl.DefaultGitRepository.getCommitForTag(DefaultGitRepository.java:90)
    at net.ontrack.extension.git.client.impl.DefaultGitClient.log(DefaultGitClient.java:97)

@dcoraboeuf
Copy link
Owner

Code corrected by #245. Can you check the ticket again since I could not reproduce it in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants