Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to the the icon and webui labels not upheld #9

Open
arifer612 opened this issue Jun 24, 2022 · 2 comments · May be fixed by #10
Open

Changes to the the icon and webui labels not upheld #9

arifer612 opened this issue Jun 24, 2022 · 2 comments · May be fixed by #10

Comments

@arifer612
Copy link

This is in reference to the issue brought up in the unRAID forum
post
by Agent531C. Changes to net.unraid.docker.icon and net.unraid.docker.webui
are not reflected after running either compose up or compose down. The
reason for this is that unRAID stores all the information in the cache and does
not clear it unless 1 of 2 situations occur:

  1. When /usr/local/emhttp/state/plugins/dynamix.docker.manager/docker.json and
    its related files are deleted.
  2. The whole Docker XML templates are re-evaluated to build all the files
    (usually on a reboot).

While it would be great to implement the changes to the unRAID OS, the fact of
the matter is that docker compose is not officially supported yet. It would be
more appropriate for now to have these changes implemented as part of how
compose projects are spun up and down in this plugin. It is possible for
example, delete a project's services from the docker.json file to ensure that
webui labels are properly updated whenever a project is spun up again. For
icons, deleting the relevant image files in both
/usr/local/emhttp/state/plugins/dynamix.docker.manager/images and
/var/lib/docker/unraid/images should be sufficient to force unRAID to retrieve
the correct image.
@arifer612 arifer612 linked a pull request Jun 24, 2022 that will close this issue
Open
@dcflachs
Copy link
Owner

dcflachs commented Jun 24, 2022 •
edited
Loading

While it would be great to implement the changes to the unRAID OS, the fact of
the matter is that docker compose is not officially supported yet. It would be
more appropriate for now to have these changes implemented as part of how
compose projects are spun up and down in this plugin.

The ability to specify images using labels is a feature of unRAID 6.10. If this is not working correctly due to their caching mechanism i would rather raise the issue to them first than try to patch around it myself. Especially since handling of icon labels is not yet built into this plugin.

@arifer612
Copy link
Author

arifer612 commented Jun 25, 2022 •
edited
Loading

If you intend to raise it up as an issue upstream, there will necessarily be a
discussion on implementing docker compose support natively on unRAID. While they
have been moving forward by adding support for icons and webui through labels,
there has not been any news of officially supporting docker compose. The forum
requesting the feature is representative of that.

If we look back at the git logs for limetech/webgui, the last commit relating to
matters of docker labels by a maintainer was 13 months ago. The implementation
was rudimentary and not complete. I highly doubt that raising it upstream would
get the positive response that we are hoping for. In the end, it is your call
and I respect that. I've put up a PR resolving this issue but there's not saying
that changes upstream would not break things again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensuring changes to icon/webui labels are respected arifer612/compose_plugin
2 participants
@dcflachs @arifer612