Handle non-UTF-8 device models #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took me a while to figure out why Fedora 40 installer was dying on me
on a Wyse 3040 thin client and I finally narrowed it down to pyparted
and found the associated issue (linked).
The fix proposed in the issue comments worked for me so I figured I'd
send a PR.
Before:
>>> import parted
>>> parted.getDevice('/dev/mmcblk0').model
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/root/pyparted/build/lib.linux-x86_64-cpython-312/parted/device.py", line 69, in model
return self.__device.model
^^^^^^^^^^^^^^^^^^^
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x92 in position 9: invalid start byte
After:
>>> import parted
>>> parted.getDevice('/dev/mmcblk0').model
'MMC H8G4a�'
Resolves: dcantrell#76
jstasiak
force-pushed
the
handle-non-utf-8-model
branch
from
4988770 to
17687ec
Compare
dcantrell
approved these changes
Jan 17, 2025
|
Ugh, totally unintentional and I agree with you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took me a while to figure out why Fedora 40 installer was dying on me on a Wyse 3040 thin client and I finally narrowed it down to pyparted and found the associated issue (linked).
The fix proposed in the issue comments worked for me so I figured I'd send a PR.
Before:
After:
Resolves: #76