Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regexp_intr shim support for dbt-expectations macro #29

Open
fivetran-joemarkiewicz opened this issue Dec 19, 2022 · 2 comments
Open

Regexp_intr shim support for dbt-expectations macro #29

fivetran-joemarkiewicz opened this issue Dec 19, 2022 · 2 comments

Comments

@fivetran-joemarkiewicz
Copy link

fivetran-joemarkiewicz commented Dec 19, 2022

Since dbt-expectations removed support for the Databricks and Spark macro compatibility of their macros, I believe it would be best to move some support of these macros into this package.

I currently have a working version of the regexp_instr macro for spark that is outlined within the dbt-expectations PR #226. Claus makes a great point to instead move this PR into this project. Before moving forward with opening a PR I wanted to confirm this approach is the desired way forward within this Issue. Specifically, I noticed the last release was almost a year ago. Would you prefer to continue adding to this project, or is this a shim we should instead provide for our packages within fivetran_utils?

Let me know what you feel the best path forward would be. Thanks!

@followingell
Copy link

Following since I raised a similar issue in dbt-expectations: https://github.com/calogica/dbt-expectations/issues/228.

@fivetran-joemarkiewicz
Copy link
Author

I ended up having some available time today and opened the above PR to incorporate dbt-expectations dispatches. I only added a shim for regexp_instr but added the folder so more may be added in the future if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants