From e4033b72084c781a9921e59e010122a37324bcea Mon Sep 17 00:00:00 2001 From: Courtney Holcomb Date: Wed, 24 Jan 2024 12:02:06 -0800 Subject: [PATCH] Use appropriate variable name --- metricflow/dataflow/builder/dataflow_plan_builder.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/metricflow/dataflow/builder/dataflow_plan_builder.py b/metricflow/dataflow/builder/dataflow_plan_builder.py index 46c0b051ca..99bbf4289a 100644 --- a/metricflow/dataflow/builder/dataflow_plan_builder.py +++ b/metricflow/dataflow/builder/dataflow_plan_builder.py @@ -698,15 +698,15 @@ def _contains_multihop_linkables(linkable_specs: Sequence[LinkableInstanceSpec]) """Returns true if any of the linkable specs requires a multi-hop join to realize.""" return any(len(x.entity_links) > 1 for x in linkable_specs) - def _get_semantic_model_names_for_measures(self, measure_names: Sequence[MeasureSpec]) -> Set[str]: + def _get_semantic_model_names_for_measures(self, measures: Sequence[MeasureSpec]) -> Set[str]: """Return the names of the semantic models needed to compute the input measures. This is a temporary method for use in assertion boundaries while we implement support for multiple semantic models """ semantic_model_names: Set[str] = set() - for measure_name in measure_names: + for measure in measures: semantic_model_names = semantic_model_names.union( - {d.name for d in self._semantic_model_lookup.get_semantic_models_for_measure(measure_name.reference)} + {d.name for d in self._semantic_model_lookup.get_semantic_models_for_measure(measure.reference)} ) return semantic_model_names