From ee061f1ff71f1fabb40f7946e017554b28d8789f Mon Sep 17 00:00:00 2001 From: Courtney Holcomb Date: Wed, 21 Aug 2024 12:45:29 -0700 Subject: [PATCH] Improve log again (#1377) Last improvement for this log didn't actually help because the data set, when printed, does not display any of its properties. Printing the instance sets instead. --- metricflow/plan_conversion/dataflow_to_sql.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/metricflow/plan_conversion/dataflow_to_sql.py b/metricflow/plan_conversion/dataflow_to_sql.py index ddb2024609..ecfef1eb20 100644 --- a/metricflow/plan_conversion/dataflow_to_sql.py +++ b/metricflow/plan_conversion/dataflow_to_sql.py @@ -925,8 +925,9 @@ def visit_combine_aggregated_outputs_node(self, node: CombineAggregatedOutputsNo assert all( [set(x.data_set.instance_set.spec_set.linkable_specs) == set(linkable_specs) for x in join_data_sets] ), ( - "All join data sets should have the same set of linkable instances as the from dataset since all values are coalesced. " - f"Got from dataset: {from_data_set}\nGot join datasets: {join_data_sets}" + "All join data sets should have the same set of linkable instances as the from dataset since all values are coalesced.\n" + f"From dataset instance set: {from_data_set.data_set.instance_set}\n" + f"Join dataset instance sets: {[join_data_set.data_set.instance_set for join_data_set in join_data_sets]}" ) linkable_spec_set = from_data_set.data_set.instance_set.spec_set.transform(SelectOnlyLinkableSpecs())