From ec06c842eb0df3ebf4987e211d5dc8bcf615d390 Mon Sep 17 00:00:00 2001 From: Courtney Holcomb Date: Wed, 16 Oct 2024 11:50:25 -0700 Subject: [PATCH] PR feedback --- metricflow/plan_conversion/dataflow_to_sql.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/metricflow/plan_conversion/dataflow_to_sql.py b/metricflow/plan_conversion/dataflow_to_sql.py index 764de7ca1a..b658ddce0d 100644 --- a/metricflow/plan_conversion/dataflow_to_sql.py +++ b/metricflow/plan_conversion/dataflow_to_sql.py @@ -328,7 +328,7 @@ def _make_time_spine_data_set( # Where constraints must be applied in an outer query since they are using an alias (e.g., 'metric_time__day'), # and some engines do not support using an alias in the WHERE clause. - if not time_spine_where_constraints: + if len(time_spine_where_constraints) == 0: return SqlDataSet(instance_set=output_instance_set, sql_select_node=inner_sql_select_node) # Build outer query to apply where constraints.