From e2dbc8c1112dbc17294a344d763fd2b4c4c55a75 Mon Sep 17 00:00:00 2001
From: tlento <tom@transformdata.io>
Date: Wed, 10 Apr 2024 16:20:13 -0700
Subject: [PATCH] Add missing aliases to integration test check queries

Most engines don't require this, but several do, including
all Postgres versions prior to Postgres 16, so we should
probably keep including the subquery aliases for now.
---
 tests/integration/test_cases/itest_dimensions.yaml | 10 +++++-----
 tests/integration/test_cases/itest_metrics.yaml    | 12 ++++++------
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/tests/integration/test_cases/itest_dimensions.yaml b/tests/integration/test_cases/itest_dimensions.yaml
index fd62bf4fb3..7cc89a5b43 100644
--- a/tests/integration/test_cases/itest_dimensions.yaml
+++ b/tests/integration/test_cases/itest_dimensions.yaml
@@ -184,7 +184,7 @@ integration_test:
         , u.home_state_latest AS user__home_state_latest
       FROM {{ source_schema }}.dim_listings_latest l
       FULL OUTER JOIN {{ source_schema }}.dim_users_latest u ON l.user_id = u.user_id
-    )
+    ) outer_subq
     WHERE listing__country_latest = 'us'
     GROUP BY user__home_state_latest
 ---
@@ -295,7 +295,7 @@ integration_test:
       FROM {{ source_schema }}.dim_users u
       GROUP BY
         u.home_state
-    )
+    ) outer_subq
 ---
 integration_test:
   name: min_max_only_time
@@ -313,7 +313,7 @@ integration_test:
       FROM {{ source_schema }}.fct_id_verifications v
       GROUP BY
         v.ds
-    )
+    ) outer_subq
 ---
 integration_test:
   name: min_max_only_time_month
@@ -331,7 +331,7 @@ integration_test:
       FROM {{ source_schema }}.fct_id_verifications v
       GROUP BY
         {{ render_date_trunc("v.ds", TimeGranularity.MONTH) }}
-    )
+    ) outer_subq
 ---
 integration_test:
   name: min_max_metric_time
@@ -367,6 +367,6 @@ integration_test:
         GROUP BY listing_id
       ) a
       ON l.listing_id = a.listing
-    )
+    ) outer_subq
     WHERE listing__bookings > 2
     GROUP BY listing
diff --git a/tests/integration/test_cases/itest_metrics.yaml b/tests/integration/test_cases/itest_metrics.yaml
index bbf4216ba9..1006c2409e 100644
--- a/tests/integration/test_cases/itest_metrics.yaml
+++ b/tests/integration/test_cases/itest_metrics.yaml
@@ -1682,7 +1682,7 @@ integration_test:
       ) subq_2
       ON {{ render_date_sub("subq_3", "metric_time__day", 5, TimeGranularity.DAY) }} = subq_2.metric_time__day
       GROUP BY subq_3.metric_time__day
-    )
+    ) outer_subq
 ---
 integration_test:
   name: cumulative_time_offset_metric_with_time_constraint
@@ -1762,7 +1762,7 @@ integration_test:
         ON {{ render_date_sub("subq_10", "ds", 2, TimeGranularity.DAY) }} = subq_8.metric_time__day
       ) subq_11
       WHERE booking__is_instant
-    )
+    ) outer_subq
 ---
 integration_test:
   name: offset_window_with_agg_time_dim
@@ -1964,7 +1964,7 @@ integration_test:
         ) c
         ON b.listing_id = c.listing_id
         GROUP BY COALESCE(b.listing_id, c.listing_id)
-      )
+      ) inner_from_subq
     ) d ON a.listing_id = d.listing_id
     WHERE listing__views_times_booking_value > 2
 ---
@@ -1990,7 +1990,7 @@ integration_test:
         GROUP BY listing_id
       ) b
       ON a.listing_id = b.listing_id
-    )
+    ) outer_subq
     WHERE listing__bookings_per_booker > 2
 ---
 integration_test:
@@ -2013,7 +2013,7 @@ integration_test:
         FROM {{ source_schema }}.fct_revenue
         GROUP BY user_id
       ) b ON a.user_id = b.user_id
-    )
+    ) outer_subq
     WHERE user__revenue_all_time > 2
 ---
 integration_test:
@@ -2045,5 +2045,5 @@ integration_test:
         FROM {{ source_schema }}.fct_bookings
         GROUP BY listing_id
       ) c ON a.listing_id = c.listing_id
-    )
+    ) outer_subq
     WHERE listing__bookings > 2 AND listing__bookers > 1