From e0cb00f79b7a3b5d53b0c8b952e397bc89b5407e Mon Sep 17 00:00:00 2001 From: Courtney Holcomb Date: Fri, 3 Nov 2023 11:16:52 -0700 Subject: [PATCH] Switch to OUTER JOIN for derived metrics --- metricflow/dataflow/builder/dataflow_plan_builder.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/metricflow/dataflow/builder/dataflow_plan_builder.py b/metricflow/dataflow/builder/dataflow_plan_builder.py index 32634cb0c5..77aaf112cf 100644 --- a/metricflow/dataflow/builder/dataflow_plan_builder.py +++ b/metricflow/dataflow/builder/dataflow_plan_builder.py @@ -248,7 +248,7 @@ def _build_metrics_output_node( queried_linkable_specs=queried_linkable_specs, where_constraint=where_constraint, time_range_constraint=time_range_constraint, - combine_metrics_join_type=SqlJoinType.INNER, + combine_metrics_join_type=SqlJoinType.FULL_OUTER if MetricType.DERIVED else SqlJoinType.INNER, ), metric_specs=[metric_spec], )