From a9a15273bcbbeb829b8402bb2fc8a69863137093 Mon Sep 17 00:00:00 2001 From: Courtney Holcomb Date: Fri, 10 Nov 2023 14:08:20 -0800 Subject: [PATCH] Comment --- metricflow/dataflow/builder/dataflow_plan_builder.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/metricflow/dataflow/builder/dataflow_plan_builder.py b/metricflow/dataflow/builder/dataflow_plan_builder.py index 8a29e1fd7a..260aa2e5ca 100644 --- a/metricflow/dataflow/builder/dataflow_plan_builder.py +++ b/metricflow/dataflow/builder/dataflow_plan_builder.py @@ -614,7 +614,8 @@ def _find_dataflow_recipe( # Dict from the node that contains the source node to the evaluation results. node_to_evaluation: Dict[BaseOutput, LinkableInstanceSatisfiabilityEvaluation] = {} - + # If only dimensions, and one is metric_time, will require cross-join! + # If only dimensions, will require full outer join! for node in self._sort_by_suitability(potential_source_nodes): data_set = self._node_data_set_resolver.get_output_data_set(node)