diff --git a/metricflow/execution/dataflow_to_execution.py b/metricflow/execution/dataflow_to_execution.py index 221eb225e6..fa0b7ccbbf 100644 --- a/metricflow/execution/dataflow_to_execution.py +++ b/metricflow/execution/dataflow_to_execution.py @@ -30,7 +30,7 @@ from metricflow.execution.convert_to_execution_plan import ConvertToExecutionPlanResult from metricflow.execution.execution_plan import ( ExecutionPlan, - SelectSqlQueryToDataFrameTask, + SelectSqlQueryToDataTableTask, SelectSqlQueryToTableTask, ) from metricflow.plan_conversion.convert_to_sql_plan import ConvertToSqlPlanResult @@ -79,7 +79,7 @@ def visit_write_to_result_data_table_node(self, node: WriteToResultDataTableNode render_sql_result = self._render_sql(convert_to_sql_plan_result) execution_plan = ExecutionPlan( leaf_tasks=( - SelectSqlQueryToDataFrameTask( + SelectSqlQueryToDataTableTask( sql_client=self._sql_client, sql_query=render_sql_result.sql, bind_parameters=render_sql_result.bind_parameters, diff --git a/metricflow/execution/execution_plan.py b/metricflow/execution/execution_plan.py index f28899d09c..5f3e8e6f18 100644 --- a/metricflow/execution/execution_plan.py +++ b/metricflow/execution/execution_plan.py @@ -86,7 +86,7 @@ class TaskExecutionResult: df: Optional[MetricFlowDataTable] = None -class SelectSqlQueryToDataFrameTask(ExecutionPlanTask): +class SelectSqlQueryToDataTableTask(ExecutionPlanTask): """A task that runs a SELECT and puts that result into a data_table.""" def __init__( # noqa: D107 diff --git a/tests_metricflow/execution/test_tasks.py b/tests_metricflow/execution/test_tasks.py index 6ca227a05f..3168476b8e 100644 --- a/tests_metricflow/execution/test_tasks.py +++ b/tests_metricflow/execution/test_tasks.py @@ -8,7 +8,7 @@ from metricflow.data_table.mf_table import MetricFlowDataTable from metricflow.execution.execution_plan import ( ExecutionPlan, - SelectSqlQueryToDataFrameTask, + SelectSqlQueryToDataTableTask, SelectSqlQueryToTableTask, ) from metricflow.execution.executor import SequentialPlanExecutor @@ -18,7 +18,7 @@ def test_read_sql_task(sql_client: SqlClient) -> None: # noqa: D103 - task = SelectSqlQueryToDataFrameTask(sql_client, "SELECT 1 AS foo", SqlBindParameters()) + task = SelectSqlQueryToDataTableTask(sql_client, "SELECT 1 AS foo", SqlBindParameters()) execution_plan = ExecutionPlan(leaf_tasks=[task], dag_id=DagId.from_str("plan0")) results = SequentialPlanExecutor().execute_plan(execution_plan)