From 488e029a83f17be473def6968c2878679b2200a8 Mon Sep 17 00:00:00 2001 From: Paul Yang Date: Wed, 15 May 2024 11:13:10 -0700 Subject: [PATCH] Address comments. --- .../model/semantics/linkable_element.py | 7 ------- .../model/semantics/linkable_spec_resolver.py | 1 + 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/metricflow-semantics/metricflow_semantics/model/semantics/linkable_element.py b/metricflow-semantics/metricflow_semantics/model/semantics/linkable_element.py index e083e8eccd..f7d6b56706 100644 --- a/metricflow-semantics/metricflow_semantics/model/semantics/linkable_element.py +++ b/metricflow-semantics/metricflow_semantics/model/semantics/linkable_element.py @@ -220,13 +220,6 @@ def metric_reference(self) -> MetricReference: # noqa: D102 def reference(self) -> GroupByMetricReference: # noqa: D102 return GroupByMetricReference(self.metric_reference.element_name) - @property - def join_by_semantic_model(self) -> Optional[SemanticModelReference]: # noqa: D102 - if len(self.join_path.semantic_model_join_path.path_elements) == 0: - return None - - return self.join_path.semantic_model_join_path.last_semantic_model_reference - @property @override def derived_from_semantic_models(self) -> Sequence[SemanticModelReference]: diff --git a/metricflow-semantics/metricflow_semantics/model/semantics/linkable_spec_resolver.py b/metricflow-semantics/metricflow_semantics/model/semantics/linkable_spec_resolver.py index ef32c14abe..3928af74ce 100644 --- a/metricflow-semantics/metricflow_semantics/model/semantics/linkable_spec_resolver.py +++ b/metricflow-semantics/metricflow_semantics/model/semantics/linkable_spec_resolver.py @@ -286,6 +286,7 @@ def get_joinable_metrics_for_semantic_model( f"last join path element: {using_join_path.last_semantic_model_reference.semantic_model_name}", ) # Temp: disable LinkableMetrics with outer join path until there is an interface to specify it. + # The result's properties = properties.union(frozenset({LinkableElementProperty.MULTI_HOP})) return LinkableElementSet() path_key_to_linkable_metrics: Dict[ElementPathKey, Tuple[LinkableMetric, ...]] = {}