From 42c88d81b8e046179da1efa3f1b6eac8c7d51157 Mon Sep 17 00:00:00 2001 From: Courtney Holcomb Date: Tue, 24 Sep 2024 08:46:16 -0700 Subject: [PATCH] Cleanup --- metricflow/sql/optimizer/column_pruner.py | 1 - 1 file changed, 1 deletion(-) diff --git a/metricflow/sql/optimizer/column_pruner.py b/metricflow/sql/optimizer/column_pruner.py index cd52be779d..d8a4cf5340 100644 --- a/metricflow/sql/optimizer/column_pruner.py +++ b/metricflow/sql/optimizer/column_pruner.py @@ -122,7 +122,6 @@ def visit_select_statement_node(self, node: SqlSelectStatementNode) -> SqlQueryP or select_column in node.group_bys or node.distinct ) - # TODO: don't prune column if it's used in join on condition if len(pruned_select_columns) == 0: raise RuntimeError("All columns have been pruned - this indicates an bug in the pruner or in the inputs.")