Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing content #6437

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Update contributing content #6437

merged 4 commits into from
Nov 8, 2024

Conversation

runleonarun
Copy link
Collaborator

What are you changing in this pull request and why?

Need to update a few things:

  • Cypress tests are no longer necessary because we have CI tests
  • Removing dev blog contribution docs - moving the blog

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

@runleonarun runleonarun requested a review from a team as a code owner November 7, 2024 22:28
@vercel Vercel
Copy link

vercel bot commented Nov 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 8, 2024 9:49pm

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Nov 7, 2024
@runleonarun runleonarun changed the title Update README.md Update contributing content Nov 7, 2024
mirnawong1
mirnawong1 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @runleonarun ! however i dont see any removal of the blog:

Removing dev blog contribution docs - moving the blog

@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Nov 8, 2024
@runleonarun runleonarun enabled auto-merge (squash) November 8, 2024 21:49
@runleonarun
Copy link
Collaborator Author

Thanks Mirna! The file is in there now. You were faster than me :)

@runleonarun runleonarun merged commit 7fee174 into current Nov 8, 2024
10 checks passed
@runleonarun runleonarun deleted the updaign-contributing-content branch November 8, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@runleonarun @mirnawong1