From 24312b3f07dc958dfcabfdf6444a34ae9b2eaadf Mon Sep 17 00:00:00 2001 From: mirnawong1 Date: Wed, 14 Feb 2024 17:28:54 +0000 Subject: [PATCH 1/5] update to accept strings + commas --- website/src/components/lifeCycle/index.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/website/src/components/lifeCycle/index.js b/website/src/components/lifeCycle/index.js index d4e4eab88d8..88bc6f12e4b 100644 --- a/website/src/components/lifeCycle/index.js +++ b/website/src/components/lifeCycle/index.js @@ -22,8 +22,10 @@ export default function Lifecycle(props) { if (!props.status || (Array.isArray(props.status) && props.status.length === 0)) { return null; } - // Check if props.status is an array or a single value - const statuses = Array.isArray(props.status) ? props.status : [props.status]; + // Check if props.status is an array or a single value amd to handle strings separated by commas + const statuses = typeof props.status ==='string' + ?props.status.split(',').map(s => s.trim()) + : Array.isArray(props.status) ? props.status : [props.status]; return ( <> From 487b1583541de3e576fc8f7adc778b02d5a56ed7 Mon Sep 17 00:00:00 2001 From: mirnawong1 Date: Wed, 14 Feb 2024 17:32:17 +0000 Subject: [PATCH 2/5] test pr --- website/docs/docs/use-dbt-semantic-layer/quickstart-sl.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/website/docs/docs/use-dbt-semantic-layer/quickstart-sl.md b/website/docs/docs/use-dbt-semantic-layer/quickstart-sl.md index 11a610805a9..4abe185d2d8 100644 --- a/website/docs/docs/use-dbt-semantic-layer/quickstart-sl.md +++ b/website/docs/docs/use-dbt-semantic-layer/quickstart-sl.md @@ -8,6 +8,8 @@ meta: api_name: dbt Semantic Layer APIs --- +### test + import CreateModel from '/snippets/_sl-create-semanticmodel.md'; import DefineMetrics from '/snippets/_sl-define-metrics.md'; import ConfigMetric from '/snippets/_sl-configure-metricflow.md'; From ee1212f98fff72fbad80d1e7d3516e95caf071f6 Mon Sep 17 00:00:00 2001 From: mirnawong1 Date: Wed, 14 Feb 2024 18:30:11 +0000 Subject: [PATCH 3/5] fold in jason's feedback --- .../docs/docs/use-dbt-semantic-layer/quickstart-sl.md | 2 -- website/src/components/lifeCycle/index.js | 9 +++++---- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/website/docs/docs/use-dbt-semantic-layer/quickstart-sl.md b/website/docs/docs/use-dbt-semantic-layer/quickstart-sl.md index 4abe185d2d8..11a610805a9 100644 --- a/website/docs/docs/use-dbt-semantic-layer/quickstart-sl.md +++ b/website/docs/docs/use-dbt-semantic-layer/quickstart-sl.md @@ -8,8 +8,6 @@ meta: api_name: dbt Semantic Layer APIs --- -### test - import CreateModel from '/snippets/_sl-create-semanticmodel.md'; import DefineMetrics from '/snippets/_sl-define-metrics.md'; import ConfigMetric from '/snippets/_sl-configure-metricflow.md'; diff --git a/website/src/components/lifeCycle/index.js b/website/src/components/lifeCycle/index.js index 88bc6f12e4b..0c6978582e3 100644 --- a/website/src/components/lifeCycle/index.js +++ b/website/src/components/lifeCycle/index.js @@ -19,13 +19,14 @@ const fontColors = { }; export default function Lifecycle(props) { + const statuses = props.status?.split(',') + if (!statuses?.length) { + return null; + } + if (!props.status || (Array.isArray(props.status) && props.status.length === 0)) { return null; } - // Check if props.status is an array or a single value amd to handle strings separated by commas - const statuses = typeof props.status ==='string' - ?props.status.split(',').map(s => s.trim()) - : Array.isArray(props.status) ? props.status : [props.status]; return ( <> From dcfd67953ad8ae25a39d27bceafb72980a526ca4 Mon Sep 17 00:00:00 2001 From: Jason Karlavige Date: Wed, 14 Feb 2024 14:55:35 -0500 Subject: [PATCH 4/5] adjust if check and add component variations to test build --- website/docs/docs/introduction.md | 8 ++++---- website/src/components/lifeCycle/index.js | 6 +----- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/website/docs/docs/introduction.md b/website/docs/docs/introduction.md index f4fb6e64d53..915dd446c51 100644 --- a/website/docs/docs/introduction.md +++ b/website/docs/docs/introduction.md @@ -11,21 +11,21 @@ dbt compiles and runs your analytics code against your data platform, enabling y Read more about why we want to enable analysts to work more like software engineers in [The dbt Viewpoint](/community/resources/viewpoint). -## dbt optimizes your workflow +## dbt optimizes your workflow - Avoid writing boilerplate  and by managing transactions, dropping tables, and managing schema changes. Write business logic with just a SQL `select` statement, or a Python DataFrame, that returns the dataset you need, and dbt takes care of . - Build up reusable, or modular, data models that can be referenced in subsequent work instead of starting at the raw data with every analysis. - Dramatically reduce the time your queries take to run: Leverage metadata to find long-running models that you want to optimize and use [incremental models](/docs/build/incremental-models) which dbt makes easy to configure and use. - Write er code by leveraging [macros](/docs/build/jinja-macros), [hooks](/docs/build/hooks-operations), and [package management](/docs/build/packages). -## dbt provides more reliable analysis +## dbt provides more reliable analysis - No longer copy and paste SQL, which can lead to errors when logic changes. Instead, build reusable data models that get pulled into subsequent models and analysis. Change a model once and that change will propagate to all its dependencies. - Publish the canonical version of a particular data model, encapsulating all complex business logic. All analysis on top of this model will incorporate the same business logic without needing to reimplement it. - Use mature source control processes like branching, pull requests, and code reviews. - Write data quality tests quickly and easily on the underlying data. Many analytic errors are caused by edge cases in the data: testing helps analysts find and handle those edge cases. -## dbt products +## dbt products You can access dbt using dbt Core or dbt Cloud. dbt Cloud is built around dbt Core, but it also provides: @@ -36,7 +36,7 @@ You can access dbt using dbt Core or dbt Cloud. dbt Cloud is built around dbt Co You can learn about plans and pricing on [www.getdbt.com](https://www.getdbt.com/pricing/). -### dbt Cloud +### dbt Cloud dbt Cloud is the fastest and most reliable way to deploy dbt. Develop, test, schedule, and investigate data models all in one web-based UI. It also natively supports developing using a command line with the [dbt Cloud CLI](/docs/cloud/cloud-cli-installation). Learn more about [dbt Cloud features](/docs/cloud/about-cloud/dbt-cloud-features) and try one of the [dbt Cloud quickstarts](/guides). diff --git a/website/src/components/lifeCycle/index.js b/website/src/components/lifeCycle/index.js index 0c6978582e3..d8abc142162 100644 --- a/website/src/components/lifeCycle/index.js +++ b/website/src/components/lifeCycle/index.js @@ -20,11 +20,7 @@ const fontColors = { export default function Lifecycle(props) { const statuses = props.status?.split(',') - if (!statuses?.length) { - return null; - } - - if (!props.status || (Array.isArray(props.status) && props.status.length === 0)) { + if (!props.status || !statuses?.length) { return null; } From a587301631f17d19a1c2a0a4cac9421358a94539 Mon Sep 17 00:00:00 2001 From: Jason Karlavige Date: Wed, 14 Feb 2024 15:13:21 -0500 Subject: [PATCH 5/5] revert test changes --- website/docs/docs/introduction.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/website/docs/docs/introduction.md b/website/docs/docs/introduction.md index 915dd446c51..f4fb6e64d53 100644 --- a/website/docs/docs/introduction.md +++ b/website/docs/docs/introduction.md @@ -11,21 +11,21 @@ dbt compiles and runs your analytics code against your data platform, enabling y Read more about why we want to enable analysts to work more like software engineers in [The dbt Viewpoint](/community/resources/viewpoint). -## dbt optimizes your workflow +## dbt optimizes your workflow - Avoid writing boilerplate  and by managing transactions, dropping tables, and managing schema changes. Write business logic with just a SQL `select` statement, or a Python DataFrame, that returns the dataset you need, and dbt takes care of . - Build up reusable, or modular, data models that can be referenced in subsequent work instead of starting at the raw data with every analysis. - Dramatically reduce the time your queries take to run: Leverage metadata to find long-running models that you want to optimize and use [incremental models](/docs/build/incremental-models) which dbt makes easy to configure and use. - Write er code by leveraging [macros](/docs/build/jinja-macros), [hooks](/docs/build/hooks-operations), and [package management](/docs/build/packages). -## dbt provides more reliable analysis +## dbt provides more reliable analysis - No longer copy and paste SQL, which can lead to errors when logic changes. Instead, build reusable data models that get pulled into subsequent models and analysis. Change a model once and that change will propagate to all its dependencies. - Publish the canonical version of a particular data model, encapsulating all complex business logic. All analysis on top of this model will incorporate the same business logic without needing to reimplement it. - Use mature source control processes like branching, pull requests, and code reviews. - Write data quality tests quickly and easily on the underlying data. Many analytic errors are caused by edge cases in the data: testing helps analysts find and handle those edge cases. -## dbt products +## dbt products You can access dbt using dbt Core or dbt Cloud. dbt Cloud is built around dbt Core, but it also provides: @@ -36,7 +36,7 @@ You can access dbt using dbt Core or dbt Cloud. dbt Cloud is built around dbt Co You can learn about plans and pricing on [www.getdbt.com](https://www.getdbt.com/pricing/). -### dbt Cloud +### dbt Cloud dbt Cloud is the fastest and most reliable way to deploy dbt. Develop, test, schedule, and investigate data models all in one web-based UI. It also natively supports developing using a command line with the [dbt Cloud CLI](/docs/cloud/cloud-cli-installation). Learn more about [dbt Cloud features](/docs/cloud/about-cloud/dbt-cloud-features) and try one of the [dbt Cloud quickstarts](/guides).