Display supported incremental strategies in a tabular format #4649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
resolves #4634
What are you changing in this pull request and why?
The main aim is to be able to easily answer each of these questions:
delete+insert
strategy?A tabular representation with one column per strategy is the easiest way to answer all of the above.
Design decisions to be made
Style of the icons
Any of these could work:
✅ - Green check mark
✔️ - Heavy check mark
🟢 - Green circle
We probably wouldn't choose any of these:
☑️ - Ballot box with check
🆗 - OK button
👍 - Thumbs up
etc.
Number of tables
We have several options:
Trade-offs
I strongly prefer not staying with the status quo, or I wouldn't have opened this issue 🤣
Splitting into two separate tables would solve the key problem, but at the cost of taking up more vertical space on the page.
Keeping a single table but refactoring it would work for me.
Completely moving the default strategy information into the adapter-specific pages might be the best of all worlds. It would solve the problem at hand while preserving documentation about the default strategy that is relevant for a particular adapter. dbt-postgres and dbt-redshift in particular have caveats related to the default -- it will change depending if a
unique_key
is defined or not.🎩
Preview
v3 (final)
v2
v1
Note: I've since removed the 2nd table that has the defaults, but here's what it looked like with them:
Checklist