From 9bae47b9485a89621783dccecfa1fd09ac9c0308 Mon Sep 17 00:00:00 2001 From: Jeremy Yeo Date: Wed, 11 Oct 2023 10:16:00 +1300 Subject: [PATCH 1/8] Update lint-format.md --- website/docs/docs/cloud/dbt-cloud-ide/lint-format.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md b/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md index 8ffd83ef00e..1a31f5510cf 100644 --- a/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md +++ b/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md @@ -223,6 +223,13 @@ Currently, running SQLFluff commands from the terminal isn't supported. Make sure you're on a development branch. Formatting or Linting isn't available on "main" or "read-only" branches. +
+Why is the lint operation inconsistent with running SQLFluff out of the dbt Cloud IDE (e.g. in a GitHub Action)? + +* Double check that your SQLFluff version that is running outside of the dbt Cloud IDE is consistent with the version used within the dbt Cloud IDE (which is usually printed out in the "Code Quality" tab after a lint operation). +* If your lint operation is always passing when there exist clear rule violations - check that you are not linting a model that uses ephemeral models (dbt versions prior to 1.6 only). +
+ ## Related docs - [User interface](/docs/cloud/dbt-cloud-ide/ide-user-interface) From 3850d35bd6bd8dbd1d3d601dce8267cd487db324 Mon Sep 17 00:00:00 2001 From: mirnawong1 <89008547+mirnawong1@users.noreply.github.com> Date: Wed, 11 Oct 2023 09:40:41 +0100 Subject: [PATCH 2/8] Update lint-format.md --- website/docs/docs/cloud/dbt-cloud-ide/lint-format.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md b/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md index 1a31f5510cf..8ce9c2866a0 100644 --- a/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md +++ b/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md @@ -45,7 +45,11 @@ With the dbt Cloud IDE, you can seamlessly use [SQLFluff](https://sqlfluff.com/) - Works with Jinja and SQL, - Comes with built-in [linting rules](https://docs.sqlfluff.com/en/stable/rules.html). You can also [customize](#customize-linting) your own linting rules. - Empowers you to [enable linting](#enable-linting) with options like **Lint** (displays linting errors and recommends actions) or **Fix** (auto-fixes errors in the IDE). -- Displays a **Code Quality** tab to view code errors, and provides code quality visibility and management. +- Displays a **Code Quality** tab to view code errors, and provides code quality visibility and management. + +:::Ephemeral models not supported +Linting doesn't support ephemeral models in dbt versions 1.5 and lower. Refer to the [FAQs](#faqs) for more info. +::: ### Enable linting From 9bc678d1f82ff2445155a5bc037fa58414af481a Mon Sep 17 00:00:00 2001 From: mirnawong1 <89008547+mirnawong1@users.noreply.github.com> Date: Wed, 11 Oct 2023 09:42:07 +0100 Subject: [PATCH 3/8] Update website/docs/docs/cloud/dbt-cloud-ide/lint-format.md --- website/docs/docs/cloud/dbt-cloud-ide/lint-format.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md b/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md index 8ce9c2866a0..1140a5c17ae 100644 --- a/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md +++ b/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md @@ -228,7 +228,7 @@ Make sure you're on a development branch. Formatting or Linting isn't available
-Why is the lint operation inconsistent with running SQLFluff out of the dbt Cloud IDE (e.g. in a GitHub Action)? +Why is there inconsistent SQLFluff behavior when running outside the dbt Cloud IDE (such as a GitHub Action)? * Double check that your SQLFluff version that is running outside of the dbt Cloud IDE is consistent with the version used within the dbt Cloud IDE (which is usually printed out in the "Code Quality" tab after a lint operation). * If your lint operation is always passing when there exist clear rule violations - check that you are not linting a model that uses ephemeral models (dbt versions prior to 1.6 only). From 126fee0f31c93f8c8b87bb378aef3d8ed9a24813 Mon Sep 17 00:00:00 2001 From: mirnawong1 <89008547+mirnawong1@users.noreply.github.com> Date: Wed, 11 Oct 2023 09:43:13 +0100 Subject: [PATCH 4/8] Update website/docs/docs/cloud/dbt-cloud-ide/lint-format.md --- website/docs/docs/cloud/dbt-cloud-ide/lint-format.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md b/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md index 1140a5c17ae..b26dfc2ff8f 100644 --- a/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md +++ b/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md @@ -230,7 +230,7 @@ Make sure you're on a development branch. Formatting or Linting isn't available
Why is there inconsistent SQLFluff behavior when running outside the dbt Cloud IDE (such as a GitHub Action)? -* Double check that your SQLFluff version that is running outside of the dbt Cloud IDE is consistent with the version used within the dbt Cloud IDE (which is usually printed out in the "Code Quality" tab after a lint operation). +* Double-check your SQLFluff version matches the one in dbt Cloud IDE (found in the "Code Quality" tab after a lint operation). * If your lint operation is always passing when there exist clear rule violations - check that you are not linting a model that uses ephemeral models (dbt versions prior to 1.6 only).
From e42d3ca1ad61d047b3f2b76f902380063b902b50 Mon Sep 17 00:00:00 2001 From: mirnawong1 <89008547+mirnawong1@users.noreply.github.com> Date: Wed, 11 Oct 2023 09:44:50 +0100 Subject: [PATCH 5/8] Update website/docs/docs/cloud/dbt-cloud-ide/lint-format.md --- website/docs/docs/cloud/dbt-cloud-ide/lint-format.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md b/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md index b26dfc2ff8f..8eee6728ea0 100644 --- a/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md +++ b/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md @@ -48,7 +48,7 @@ With the dbt Cloud IDE, you can seamlessly use [SQLFluff](https://sqlfluff.com/) - Displays a **Code Quality** tab to view code errors, and provides code quality visibility and management. :::Ephemeral models not supported -Linting doesn't support ephemeral models in dbt versions 1.5 and lower. Refer to the [FAQs](#faqs) for more info. +Linting doesn't support ephemeral models in dbt v1.5 and lower. Refer to the [FAQs](#faqs) for more info. ::: ### Enable linting From 8f4fbbf09e3d1a5fe108495d3fad16b2e63ab104 Mon Sep 17 00:00:00 2001 From: mirnawong1 <89008547+mirnawong1@users.noreply.github.com> Date: Wed, 11 Oct 2023 09:45:27 +0100 Subject: [PATCH 6/8] Update website/docs/docs/cloud/dbt-cloud-ide/lint-format.md --- website/docs/docs/cloud/dbt-cloud-ide/lint-format.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md b/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md index 8eee6728ea0..fd31f63199b 100644 --- a/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md +++ b/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md @@ -231,7 +231,7 @@ Make sure you're on a development branch. Formatting or Linting isn't available Why is there inconsistent SQLFluff behavior when running outside the dbt Cloud IDE (such as a GitHub Action)? * Double-check your SQLFluff version matches the one in dbt Cloud IDE (found in the "Code Quality" tab after a lint operation). -* If your lint operation is always passing when there exist clear rule violations - check that you are not linting a model that uses ephemeral models (dbt versions prior to 1.6 only). +* If your lint operation passes despite clear rule violations, confirm you're not linting models with ephemeral models. Linting doesn't support ephemeral models in dbt v1.5 and lower.
## Related docs From 5ff477918771d25fbcd06d53ddc8db7765d6a427 Mon Sep 17 00:00:00 2001 From: mirnawong1 <89008547+mirnawong1@users.noreply.github.com> Date: Wed, 11 Oct 2023 09:48:17 +0100 Subject: [PATCH 7/8] Update lint-format.md --- website/docs/docs/cloud/dbt-cloud-ide/lint-format.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md b/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md index fd31f63199b..54d695172c9 100644 --- a/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md +++ b/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md @@ -230,8 +230,8 @@ Make sure you're on a development branch. Formatting or Linting isn't available
Why is there inconsistent SQLFluff behavior when running outside the dbt Cloud IDE (such as a GitHub Action)? -* Double-check your SQLFluff version matches the one in dbt Cloud IDE (found in the "Code Quality" tab after a lint operation). -* If your lint operation passes despite clear rule violations, confirm you're not linting models with ephemeral models. Linting doesn't support ephemeral models in dbt v1.5 and lower. +- Double-check your SQLFluff version matches the one in dbt Cloud IDE (found in the "Code Quality" tab after a lint operation). +- If your lint operation passes despite clear rule violations, confirm you're not linting models with ephemeral models. Linting doesn't support ephemeral models in dbt v1.5 and lower.
## Related docs From 0499a69aa20cc7a32d60a428628491be21d220ad Mon Sep 17 00:00:00 2001 From: mirnawong1 Date: Wed, 11 Oct 2023 10:00:51 +0100 Subject: [PATCH 8/8] fix errors --- website/docs/docs/cloud/dbt-cloud-ide/lint-format.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md b/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md index 54d695172c9..6a86f1aa14b 100644 --- a/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md +++ b/website/docs/docs/cloud/dbt-cloud-ide/lint-format.md @@ -47,7 +47,7 @@ With the dbt Cloud IDE, you can seamlessly use [SQLFluff](https://sqlfluff.com/) - Empowers you to [enable linting](#enable-linting) with options like **Lint** (displays linting errors and recommends actions) or **Fix** (auto-fixes errors in the IDE). - Displays a **Code Quality** tab to view code errors, and provides code quality visibility and management. -:::Ephemeral models not supported +:::info Ephemeral models not supported Linting doesn't support ephemeral models in dbt v1.5 and lower. Refer to the [FAQs](#faqs) for more info. ::: @@ -229,9 +229,8 @@ Make sure you're on a development branch. Formatting or Linting isn't available
Why is there inconsistent SQLFluff behavior when running outside the dbt Cloud IDE (such as a GitHub Action)? - -- Double-check your SQLFluff version matches the one in dbt Cloud IDE (found in the "Code Quality" tab after a lint operation). -- If your lint operation passes despite clear rule violations, confirm you're not linting models with ephemeral models. Linting doesn't support ephemeral models in dbt v1.5 and lower. +— Double-check your SQLFluff version matches the one in dbt Cloud IDE (found in the Code Quality tab after a lint operation).

+— If your lint operation passes despite clear rule violations, confirm you're not linting models with ephemeral models. Linting doesn't support ephemeral models in dbt v1.5 and lower.
## Related docs