Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all snapshot_meta_column_names including dbt_is_deleted should be a string input not a boolean #6747

Closed
1 task done
graciegoheen opened this issue Jan 9, 2025 · 3 comments · Fixed by #6749
Closed
1 task done
Assignees
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@graciegoheen
Copy link
Collaborator

graciegoheen commented Jan 9, 2025

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/resource-configs/snapshot_meta_column_names

What part(s) of the page would you like to see updated?

Right now it says to input a boolean for snapshot_meta_column_names dbt_is_deleted:

snapshots:
  - name: <snapshot_name>
    config:
      snapshot_meta_column_names:
        dbt_valid_from: <string>
        dbt_valid_to: <string>
        dbt_scd_id: <string>
        dbt_updated_at: <string>
        dbt_is_deleted: <boolean>

Instead it should be a string:

snapshots:
  - name: <snapshot_name>
    config:
      snapshot_meta_column_names:
        dbt_valid_from: <string>
        dbt_valid_to: <string>
        dbt_scd_id: <string>
        dbt_updated_at: <string>
        dbt_is_deleted: <string>

Additional information

No response

@graciegoheen graciegoheen added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Jan 9, 2025
@mirnawong1 mirnawong1 self-assigned this Jan 9, 2025
@mirnawong1
Copy link
Contributor

mirnawong1 commented Jan 9, 2025

hey @graciegoheen , so since it's a string - the user can still input 'yes' or 'no'? or 'true' and 'false'? or is_deleted?

currently the definition for dbt_deleted_at is: A boolean value indicating if the record has been deleted. True if deleted, False otherwise.

@graciegoheen graciegoheen changed the title dbt_is_deleted config should be a string input not a boolean all snapshot_meta_column_names including dbt_is_deleted should be a string input not a boolean Jan 9, 2025
@graciegoheen
Copy link
Collaborator Author

That's the correct definition for the actual metadata field dbt_is_deleted but for this snapshot_meta_column_names config, you just map the dbt-provided name with what you want the name to be. So maybe you want the dbt_is_deleted field to be named grace_delete_column. The thing you input for snapshot_meta_column_names: {dbt_is_deleted: grace_delete_column} is a string. Does that make sense?

@mirnawong1
Copy link
Contributor

makes sense, thank you! i'll change the description because it still references the boolean (true/false). thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants