Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify how MF joins work #6650

Closed
1 task done
mirnawong1 opened this issue Dec 12, 2024 · 0 comments · Fixed by #6690
Closed
1 task done

Clarify how MF joins work #6650

mirnawong1 opened this issue Dec 12, 2024 · 0 comments · Fixed by #6690
Assignees
@mirnawong1
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear size: small This change will take 1 to 2 days to address

Comments

@mirnawong1
Copy link
Contributor

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/docs/build/join-logic#types-of-joins

What part(s) of the page would you like to see updated?

Based on internal slack feedback, we can 'd just say that the docs do not seem to reference using full outer joins. It just says dbt does left joins.

Greater details on how MetricFlow determines what join to do, and how to ensure that the autogenerated SQL will produce accurate results would be super helpful

Additional information

No response
@mirnawong1 mirnawong1 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear size: small This change will take 1 to 2 days to address labels Dec 12, 2024
@mirnawong1 mirnawong1 self-assigned this Dec 12, 2024
@mirnawong1 mirnawong1 mentioned this issue Dec 19, 2024
Merged
runleonarun added a commit that referenced this issue Dec 24, 2024
@mirnawong1 @runleonarun
add clarifying info on how MF joins works (#6690)
65a46f1 
this pr adds more detail about the joins supported by mf. currently it
mentions left joins but there's no info on outer joins or semantic
valiations. this pr adds more info on the types of joins available, when
they're used, semantic validations available, and practical sql examples

raised by [internal
slack](https://dbt-labs.slack.com/archives/C03KHQRQUBX/p1733947531180079)

Resolves #6650

<!-- vercel-deployment-preview -->
---
🚀 Deployment available! Here are the direct links to the updated files:


-
https://docs-getdbt-com-git-update-mf-joins-dbt-labs.vercel.app/docs/build/join-logic

<!-- end-vercel-deployment-preview -->

---------

Co-authored-by: Leona B. Campbell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirnawong1 mirnawong1

Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add clarifying info on how MF joins works dbt-labs/docs.getdbt.com
1 participant
@mirnawong1