Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Adapter support for query cancellation affects behavior of --fail-fast #5411

Open
dbeatty10 opened this issue Apr 30, 2024 · 0 comments
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core size: medium This change will take up to a week to address

Comments

@dbeatty10
Copy link
Contributor

Link to the page(s) on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/global-configs/failing-fast

Tell us more about this update

The docs currently say:

Supply the -x or --fail-fast flag to dbt run to make dbt exit immediately if a single resource fails to build. If other models are in-progress when the first model fails, then dbt will terminate the connections for these still-running models.

But this is only true if the adapter supports query cancellation.

So we should update our docs to soften the language and explain how it will behave differently depending on the capabilities of the dbt adapter that is being used.

An example

For example, dbt-postgres behaves as currently described in the docs and cancels any queries that are running concurrently:

image

But dbt-duckdb allows any concurrently running query to finish (rather than cancelling them):

image

dbt-duckdb gives this specific warning when --fail-fast is specified and there is an exception:

The duckdb adapter does not support query cancellation. Some queries may still be running!

Reviewers/Stakeholders/SMEs

.

Related GitHub issues

dbt-labs/dbt-core#10057

Additional information

No response

@dbeatty10 dbeatty10 added content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core labels Apr 30, 2024
@nataliefiann nataliefiann added the size: medium This change will take up to a week to address label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core size: medium This change will take up to a week to address
Projects
None yet
Development

No branches or pull requests

2 participants