Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistency in SL measures #5398

Closed
1 task done
SOVALINUX opened this issue Apr 29, 2024 · 1 comment · Fixed by #5408
Closed
1 task done

Fix inconsistency in SL measures #5398

SOVALINUX opened this issue Apr 29, 2024 · 1 comment · Fixed by #5408
Assignees
@mirnawong1
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@SOVALINUX
Copy link

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/docs/build/measures

What part(s) of the page would you like to see updated?

Update description for the agg in the top table by adding percentile option there:
Currently it's "dbt supports the following aggregations: sum, max, min, avg, median, count_distinct, and sum_boolean.", however in the page below it has the percentile option as well

Additional information

No response
@SOVALINUX SOVALINUX added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Apr 29, 2024
@mirnawong1
Copy link
Contributor

hey @SOVALINUX, thanks for opening this up! really appreciate it and I've flagged this internally and we'll work to clarify! ✨

@mirnawong1 mirnawong1 mentioned this issue Apr 30, 2024
Merged
@mirnawong1 mirnawong1 self-assigned this May 1, 2024
mirnawong1 added a commit that referenced this issue May 2, 2024
@mirnawong1
clarifies percentile in agg field for mesures (#5408)
b7b8772 
Updates the description for the agg in the top table by adding
percentile. Also adds add'l info on support sql engines for agg_params

Resolves  #5398


added table based on [pr
here](dbt-labs/metricflow#395) provided by
@tlento
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirnawong1 mirnawong1

Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clarifies percentile in agg field for mesures dbt-labs/docs.getdbt.com
2 participants
@SOVALINUX @mirnawong1