Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy in docs about accepted values for "on_schema_change" on contracts for incremental models. #5386

Closed
1 task done
ialdg opened this issue Apr 29, 2024 · 0 comments · Fixed by #6628
Closed
1 task done
Labels
community Contributions from the dbt community content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@ialdg
Copy link
Contributor

ialdg commented Apr 29, 2024

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/docs/collaborate/govern/model-contracts#where-are-contracts-supported
https://docs.getdbt.com/reference/resource-configs/contract#support

What part(s) of the page would you like to see updated?

Hi. In this link:
https://docs.getdbt.com/reference/resource-configs/contract#support
, it's said that: "Models materialized as table, view, and incremental (with on_schema_change: append_new_columns)"
, but in this other link:
https://docs.getdbt.com/docs/collaborate/govern/model-contracts#where-are-contracts-supported
, it's said: "incremental — with on_schema_change: append_new_columns or on_schema_change: fail"
Which one is the correct one if any?
Regards.
IL.

Additional information

No response

@ialdg ialdg added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Apr 29, 2024
@matthewshaver matthewshaver added the community Contributions from the dbt community label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Contributions from the dbt community content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants