Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix header in --empty flag docs #5355

Closed
1 task
graciegoheen opened this issue Apr 24, 2024 · 0 comments · Fixed by #5365
Closed
1 task

fix header in --empty flag docs #5355

graciegoheen opened this issue Apr 24, 2024 · 0 comments · Fixed by #5365
Labels
content Improvements or additions to content dbt-core v1.8 improvement Use this when an area of the docs needs improvement as it's currently unclear
Milestone
dbt Core v1.8 Doc...

Comments

@graciegoheen
Copy link
Collaborator

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/commands/build#details

What part(s) of the page would you like to see updated?

Screenshot 2024-04-24 at 6 12 39 PM

Fix header on empty docs

Additional information

No response
@graciegoheen graciegoheen added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Apr 24, 2024
@matthewshaver matthewshaver mentioned this issue Apr 26, 2024
Merged
3 tasks
mirnawong1 added a commit that referenced this issue Apr 26, 2024
@mirnawong1
Fixing format error (#5365)
ad73be1 
## What are you changing in this pull request and why?

Closes #5355

This was a very strange bug @graciegoheen uncovered and I'm not sure we
need to investigate further, but it's good to have this record in if it
happens again.

The header formatting wasn't working for this one particular section
(see the above issue for a screenshot). I could reproduce it locally
when I pulled it up (`npm`). Adding/removing spaces and changing the
formatting had no impact. I deleted the section and moved the `Tests`
section up, which was then impacted by the error. When I pasted the
original text back, it was suddenly fine.

Works in the preview too
https://docs-getdbt-2e8g4l6nu-dbt-labs.vercel.app/reference/commands/build#the---empty-flag

## Checklist
<!--
Uncomment when publishing docs for a prerelease version of dbt:
- [ ] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages)
- [ ] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/docs/dbt-versions/core-upgrade)
-->
- [ ] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [ ] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
- [ ] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content Improvements or additions to content dbt-core v1.8 improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
dbt Core v1.8 Documentation
Development

Successfully merging a pull request may close this issue.

Fixing format error dbt-labs/docs.getdbt.com
1 participant
@graciegoheen