Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example in profiles.yml for indirect_selection #4773

Closed
1 task done
dbeatty10 opened this issue Jan 19, 2024 · 6 comments · Fixed by #4977
Closed
1 task done

Example in profiles.yml for indirect_selection #4773

dbeatty10 opened this issue Jan 19, 2024 · 6 comments · Fixed by #4977
Assignees
Labels
content Improvements or additions to content dbt-core v1.8 improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@dbeatty10
Copy link
Contributor

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

Two pages:

The new page should work in concert with these pre-existing page sections:

What part(s) of the page would you like to see updated?

Starting in v1.8, dbt-labs/dbt-core#9040 adds indirect_selection as a global config, so we should:

  1. create a global config page for this flag
  2. update profiles.yml accordingly

If we were to just do number 2) without doing 1), then the update might look like this (with applicable version blocks, of course):

  [indirect_selection](/reference/node-selection/test-selection-examples#indirect-selection): <eager | cautious | buildable | empty>

Additional information

No response

@dbeatty10 dbeatty10 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Jan 19, 2024
@mirnawong1
Copy link
Contributor

hey @dbeatty10 is this issue for dbt v1.8?

@dbeatty10
Copy link
Contributor Author

hey @dbeatty10 is this issue for dbt v1.8?

It is!

Just added a dbt-core 1.8 label. Is there anything else we should do given that it's for v1.8?

@martynydbt martynydbt added this to the dbt Core v1.8 Documentation milestone Feb 8, 2024
@runleonarun
Copy link
Collaborator

@runleonarun adding copilot summary

This pull request primarily focuses on consolidating deferral methods and flags within the dbt project. The changes involve modifications to various methods and classes across multiple files, including core/dbt/cli/flags.py and core/dbt/cli/main.py. The most significant changes include the addition of a new params_assigned_from_user set and changes to the _assign_params method, reordering and removal of decorators in core/dbt/cli/main.py, and the introduction of defer_relation in core/dbt/contracts/graph/manifest.py.

  1. Changes to _assign_params method in core/dbt/cli/flags.py:

    • A new set params_assigned_from_user is introduced and used to track user-provided and default values across both 'parent' and 'child' levels. This is to support detection of mutually exclusive flags later on. [1] [2]
    • The _assign_params method is modified to include params_assigned_from_user as a parameter. [1] [2]
  2. Reordering and removal of decorators in core/dbt/cli/main.py:

    • Several decorators are added to the global_flags function and removed from other functions. This change is likely aimed at consolidating the use of these decorators. [1] [2] [3] and others)
  3. Introduction of defer_relation in core/dbt/contracts/graph/manifest.py:

    • For non-ephemeral refable nodes, a new defer_relation attribute is added. This attribute is used when the model is deferred and the adapter doesn't support zero-copy cloning. [1] [2]
  4. Changes in core/dbt/task/clone.py:

    • The CloneTask class now always requires a state manifest, regardless of whether the --defer flag has been set.
    • The defer_to_manifest method is removed. Unlike other commands, 'clone' always requires a state manifest.
  5. Consolidation of deferral methods and flags:

    • An 'Under the Hood' change is added to consolidate deferral methods and flags.

These changes seem to be part of a larger refactoring effort aimed at simplifying the codebase and improving the handling of deferral methods and flags.

@runleonarun
Copy link
Collaborator

Hey @dbeatty10 The linked PR doesn't mention indirect_selection as a global config. Is there another PR we should be aware of for this issue? cc @graciegoheen

@dbeatty10
Copy link
Contributor Author

Hey @dbeatty10 The linked PR doesn't mention indirect_selection as a global config. Is there another PR we should be aware of for this issue? cc @graciegoheen

@runleonarun This is indeed the correct PR!

indirect_selection was removed from individual sub commands and added to global_flags (which is included in all sub commands) within #9040.

@runleonarun runleonarun self-assigned this Feb 21, 2024
matthewshaver added a commit that referenced this issue Feb 27, 2024
resolves #4773 

## What are you changing in this pull request and why?
<!---
Describe your changes and why you're making them. If related to an open 
issue or a pull request on dbt Core, then link to them here! 

To learn more about the writing conventions used in the dbt Labs docs,
see the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md).
-->

## Checklist
<!--
Uncomment when publishing docs for a prerelease version of dbt:
- [ ] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages)
- [ ] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/docs/dbt-versions/core-upgrade)
-->
- [ ] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [ ] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
- [ ] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."

Adding or removing pages (delete if not applicable):
- [ ] Add/remove page in `website/sidebars.js`
- [ ] Provide a unique filename for new pages
- [ ] Add an entry for deleted pages in `website/static/_redirects`
- [ ] Run link testing locally with `npm run build` to update the links
that point to deleted pages
@runleonarun
Copy link
Collaborator

Closed in #4977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content dbt-core v1.8 improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants