From 18cca3fccbf5b013c1c0a6563f258fa0301a0c3f Mon Sep 17 00:00:00 2001
From: mirnawong1 <mirnawong@gmail.com>
Date: Tue, 15 Oct 2024 15:31:25 +0100
Subject: [PATCH] update

---
 .github/workflows/vale.yml | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/vale.yml b/.github/workflows/vale.yml
index 0566b837a74..ed7ce4f6a3f 100644
--- a/.github/workflows/vale.yml
+++ b/.github/workflows/vale.yml
@@ -58,22 +58,22 @@ jobs:
             fi
           done
 
-      - name: Run Vale and report errors but don't fail
+      - name: Run Vale on changed lines
         if: ${{ steps.changed-files.outputs.any_changed == 'true' }}
         id: vale-lint
         uses: errata-ai/vale-action@reviewdog
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
-          reporter: github-pr-check
-          level: error  # Report as errors instead of warnings
-          fail_on_error: false  # Ensure the check won't fail the entire CI
+          reporter: github-check  # Annotations will be posted in the PR
+          level: error  # Report as errors to make issues clearer
+          filter_mode: added  # Only analyze changed lines
           files: ${{ steps.changed-files.outputs.all_changed_and_modified_files }}
           separator: ' '
           version: '2.27.0'
-          filter_mode: added
+        continue-on-error: true  # Ensure workflow continues even if Vale finds issues
 
-      - name: Post summary comment
-        if: ${{ steps.changed-files.outputs.any_changed == 'true' }}
+      - name: Post summary comment if Vale finds issues
+        if: steps.vale-lint.outcome == 'failure'  # Check if Vale found any linting issues
         run: |
           COMMENT="❗️Oh no, some Vale linting found issues! Please check the **Files changed** tab for detailed results and make the necessary updates."
           COMMENT+=$'\n'