Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch ceil to floor #894

Closed
wants to merge 3 commits into from
Closed

Conversation

dapollak
Copy link

@dapollak dapollak commented Sep 26, 2023

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

When calculating datediff in "hour"s with spark, we get a result that is larger by 1 relatively to all other warehouses when using datediff.

Solution

Swapping CEIL and FLOOR as in all other cases

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@dapollak dapollak requested a review from a team as a code owner September 26, 2023 08:06
@dapollak dapollak requested a review from Fleid September 26, 2023 08:06
@cla-bot
Copy link

cla-bot bot commented Sep 26, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @dapollak

@cla-bot cla-bot bot added the cla:yes label Sep 26, 2023
Copy link
Contributor

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 30, 2024
Copy link
Contributor

github-actions bot commented Apr 6, 2024

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant