From 7d9edfa40fa1ed24d0ba40415799fb57c1ddd961 Mon Sep 17 00:00:00 2001 From: Michelle Ark Date: Sun, 19 Nov 2023 12:26:47 -0500 Subject: [PATCH 1/3] add tests for --empty flag --- dev-requirements.txt | 5 ++--- tests/functional/adapter/empty/test_empty.py | 5 +++++ 2 files changed, 7 insertions(+), 3 deletions(-) create mode 100644 tests/functional/adapter/empty/test_empty.py diff --git a/dev-requirements.txt b/dev-requirements.txt index c37c088f4..d79f312d1 100644 --- a/dev-requirements.txt +++ b/dev-requirements.txt @@ -1,8 +1,7 @@ # install latest changes in dbt-core # TODO: how to automate switching from develop to version branches? -git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core -git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter - +git+https://github.com/dbt-labs/dbt-core.git@dry-run-flag#egg=dbt-core&subdirectory=core +git+https://github.com/dbt-labs/dbt-core.git@dry-run-flag#egg=dbt-tests-adapter&subdirectory=tests/adapter # if version 1.x or greater -> pin to major version # if version 0.x -> pin to minor black~=23.11 diff --git a/tests/functional/adapter/empty/test_empty.py b/tests/functional/adapter/empty/test_empty.py new file mode 100644 index 000000000..37aa45f60 --- /dev/null +++ b/tests/functional/adapter/empty/test_empty.py @@ -0,0 +1,5 @@ +from dbt.tests.adapter.empty.test_empty import BaseTestEmpty + + +class TestSnowflakeEmpty(BaseTestEmpty): + pass From c6c7a5485983e58f03afb4e57ce7ed33432f4928 Mon Sep 17 00:00:00 2001 From: Michelle Ark Date: Sun, 19 Nov 2023 12:29:00 -0500 Subject: [PATCH 2/3] changelog entry --- .changes/unreleased/Under the Hood-20231119-122853.yaml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changes/unreleased/Under the Hood-20231119-122853.yaml diff --git a/.changes/unreleased/Under the Hood-20231119-122853.yaml b/.changes/unreleased/Under the Hood-20231119-122853.yaml new file mode 100644 index 000000000..06f8d5e4b --- /dev/null +++ b/.changes/unreleased/Under the Hood-20231119-122853.yaml @@ -0,0 +1,6 @@ +kind: Under the Hood +body: Add tests for --empty flag +time: 2023-11-19T12:28:53.795687-05:00 +custom: + Author: michelleark + Issue: "837" From fe33e71a2e942b2eccc196fcecc297820a1da5ab Mon Sep 17 00:00:00 2001 From: Michelle Ark Date: Fri, 1 Dec 2023 13:47:14 -0500 Subject: [PATCH 3/3] restore dev-requirements --- dev-requirements.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dev-requirements.txt b/dev-requirements.txt index d79f312d1..c37c088f4 100644 --- a/dev-requirements.txt +++ b/dev-requirements.txt @@ -1,7 +1,8 @@ # install latest changes in dbt-core # TODO: how to automate switching from develop to version branches? -git+https://github.com/dbt-labs/dbt-core.git@dry-run-flag#egg=dbt-core&subdirectory=core -git+https://github.com/dbt-labs/dbt-core.git@dry-run-flag#egg=dbt-tests-adapter&subdirectory=tests/adapter +git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core +git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter + # if version 1.x or greater -> pin to major version # if version 0.x -> pin to minor black~=23.11