ADAP-542: Add configuration options for dynamic tables #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w_count for dynamic table initialization
colin-rogers-dbt
pushed a commit
that referenced
this pull request
Jun 8, 2023
* create feature branch, point to core feature branch, add changie * ADAP-541: Stub out dynamic table (#616) * stub jinja templates with a traditional table as proxy * add dynamic_table as a relation type * setup testing framework for dynamic tables * updated dbt-snowflake to reflect changes in dbt-core * ADAP-542: Add configuration options for dynamic tables (#636) * add new config enums * added refresh strategy query and relation method to determine differences * added dynamic table ddl * tests mostly pass, fail due to dynamic table being unavailable * updated with materialized views pushed to main, added retry to get_row_count for dynamic table initialization * lag > target_lag; remove refresh statement that wasn't doing anything * fixed some typos, readability updates on tests
|
Regarding the refresh options (nowait and refresh), could there be a 3rd option called force or immediate? The behavior would be to perform a manual refresh on the dynamic table, rather than wait for the lag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #603
Description
refresh_strategyandlagas configuration optionsrelationand ddlChecklist
changie newto create a changelog entry