From 0ed1a2901e188987c316ac73fc0015c41b4fdf1f Mon Sep 17 00:00:00 2001 From: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com> Date: Wed, 17 Apr 2024 10:46:34 -0500 Subject: [PATCH] skipping a test till we decide how to best handle new truth around version expectation (#976) * update RELEASE_BRANCH env * skipping a test due to changes around how dbt_package version and dbt installed version are not always the same anymore * add changelog * update pytset.skip to pytest.mark.skip --------- Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com> --- .changes/unreleased/Fixes-20240416-203625.yaml | 6 ++++++ .../adapter/query_comment_tests/test_query_comments.py | 8 +++++++- 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 .changes/unreleased/Fixes-20240416-203625.yaml diff --git a/.changes/unreleased/Fixes-20240416-203625.yaml b/.changes/unreleased/Fixes-20240416-203625.yaml new file mode 100644 index 000000000..35125f5f7 --- /dev/null +++ b/.changes/unreleased/Fixes-20240416-203625.yaml @@ -0,0 +1,6 @@ +kind: Fixes +body: skipping a test that provides a false condition +time: 2024-04-16T20:36:25.449409-05:00 +custom: + Author: McKnight-42 + Issue: "976" diff --git a/tests/functional/adapter/query_comment_tests/test_query_comments.py b/tests/functional/adapter/query_comment_tests/test_query_comments.py index 1ce4b6c7c..8fbfcbdd8 100644 --- a/tests/functional/adapter/query_comment_tests/test_query_comments.py +++ b/tests/functional/adapter/query_comment_tests/test_query_comments.py @@ -1,3 +1,4 @@ +import pytest from dbt.tests.adapter.query_comment.test_query_comment import ( BaseQueryComments, BaseMacroQueryComments, @@ -17,7 +18,12 @@ class TestMacroQueryCommentsSnowflake(BaseMacroQueryComments): class TestMacroArgsQueryCommentsSnowflake(BaseMacroArgsQueryComments): - pass + @pytest.mark.skip( + "This test is incorrectly comparing the version of `dbt-core`" + "to the version of `dbt-snowflake`, which is not always the same." + ) + def test_matches_comment(self, project, get_package_version): + pass class TestMacroInvalidQueryCommentsSnowflake(BaseMacroInvalidQueryComments):