Validate Saved Query Names #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a stacked PR
|
This will simplify things and allow for some refactors in some upcoming commits.
QMalcolm
force-pushed
the
qmalcolm--181-validate-metric-names
branch
from
b99cc42 to
54a0648
Compare
QMalcolm
force-pushed
the
qmalcolm--180-validate-saved-query-names
branch
from
3fd724f to
07c382f
Compare
…o helper function
…date_top_level_objects`
QMalcolm
force-pushed
the
qmalcolm--180-validate-saved-query-names
branch
from
07c382f to
77b55d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #180
Description
In #148 which went out in 0.3.0, we forgot to add a validation for the saved query name. This PR adds that validation.
We plan on backporting this to 0.3.latest, which would break people who have saved queries defined with invalid name. Luckily the main thing that uses DSI is dbt-core, and dbt-core's latest production version (1.6.5) uses DSI 0.2.latest. DSI 0.3.0 is being used by dbt-core 1.7.0r1, but not many people are using that yet. Thus it's unlikely that many people have defined saved queries, and only a subset of those who have will have defined invalid names.
Checklist
changie newto create a changelog entry