diff --git a/.changes/unreleased/Fixes-20230926-092650.yaml b/.changes/unreleased/Fixes-20230926-092650.yaml new file mode 100644 index 00000000..58163cf4 --- /dev/null +++ b/.changes/unreleased/Fixes-20230926-092650.yaml @@ -0,0 +1,6 @@ +kind: Fixes +body: Change ordering of TimeDimension parameters to be backward compatible +time: 2023-09-26T09:26:50.684682-05:00 +custom: + Author: DevonFulcher + Issue: None diff --git a/dbt_semantic_interfaces/parsing/where_filter/where_filter_time_dimension.py b/dbt_semantic_interfaces/parsing/where_filter/where_filter_time_dimension.py index 7ba7dc36..f8022f45 100644 --- a/dbt_semantic_interfaces/parsing/where_filter/where_filter_time_dimension.py +++ b/dbt_semantic_interfaces/parsing/where_filter/where_filter_time_dimension.py @@ -42,9 +42,9 @@ def create( self, time_dimension_name: str, time_granularity_name: str, + entity_path: Sequence[str] = (), descending: Optional[bool] = None, date_part_name: Optional[str] = None, - entity_path: Sequence[str] = (), ) -> TimeDimensionStub: """Gets called by Jinja when rendering {{ TimeDimension(...) }}.""" if descending is not None: diff --git a/dbt_semantic_interfaces/protocols/query_interface.py b/dbt_semantic_interfaces/protocols/query_interface.py index 32ea87d7..2831740b 100644 --- a/dbt_semantic_interfaces/protocols/query_interface.py +++ b/dbt_semantic_interfaces/protocols/query_interface.py @@ -61,9 +61,9 @@ def create( self, time_dimension_name: str, time_granularity_name: str, + entity_path: Sequence[str] = (), descending: Optional[bool] = None, date_part_name: Optional[str] = None, - entity_path: Sequence[str] = (), ) -> QueryInterfaceTimeDimension: """Create a TimeDimension.""" pass