Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support use of "tags" field for SavedQuery #369

Closed
3 tasks done
theyostalservice opened this issue Nov 13, 2024 · 0 comments · Fixed by #366
Closed
3 tasks done

[Feature] Support use of "tags" field for SavedQuery #369

theyostalservice opened this issue Nov 13, 2024 · 0 comments · Fixed by #366
Labels
enhancement New feature or request

Comments

@theyostalservice
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward change to existing dbt-semantic-interfaces functionality, rather than a Big Idea better suited to a discussion

Describe the feature

By adding "tags" to saved queries like many other nodes, we unlock the ability to selectively execute a subset of saved queries with simple --select commands.

Describe alternatives you've considered

No response

Who will this benefit?

This makes the experience more consistent between semantic layer resources and other resources, and it addresses direct requests from users.

Are you interested in contributing this feature?

Yes.

Anything else?

I have already started work on this here and the accompanying changes to dbt core are in progress here.

Following a discussion with @Jstein77 , we didn't include any specific hierarchical merging because there wasn't a relevant parent to merge from.
@theyostalservice theyostalservice added the enhancement New feature or request label Nov 13, 2024
This was referenced Nov 13, 2024
Open
Merged
theyostalservice added a commit that referenced this issue Nov 14, 2024
@theyostalservice
Add tags to SavedQuery (#366)
f3a50f0 
Resolves [#369](#369)

### Description

Addresses internal Linear issue SL-2896.

Users currently can execute parts of their DAG conditionally based on tags added to individual nodes (see [documentation](https://docs.getdbt.com/reference/resource-configs/tags)).  This brings SavedQueries in line with other similar nodes and allows the use of tags as described in that documentation.  (See the added tests for examples.)

It does not add any hierarchical behaviors for these tags.

A related [PR #10987](dbt-labs/dbt-core#10987) is in progress in dbt-core.

### Checklist

- [x] I have read [the contributing guide](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md) and understand what's expected of me
- [x] I have signed the [CLA](https://docs.getdbt.com/docs/contributor-license-agreements)
- [x] This PR includes tests, or tests are not required/relevant for this PR
- [x] I have run `changie new` to [create a changelog entry](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md#adding-a-changelog-entry)
@theyostalservice theyostalservice mentioned this issue Dec 16, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tags to SavedQuery dbt-labs/dbt-semantic-interfaces
1 participant
@theyostalservice