-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-3246] Make specifying semantic layer object label
attributes optional
#351
Comments
Optional
Optional
Alternative proposal from @nhandel: Keep |
I think this is fairly intuitive as a default and relieves some of the burden of customizing every option for the laissez-faire folks. |
Removing the |
@nhandel + @jtcohen6 If it's the former then we should move to make |
I lean toward the latter approach. It feels much simpler for downstream consumers to say, "If you want a human-friendly name for this semantic object (e.g. to show in a UI), always use |
@jtcohen6 That's a good enough argument for me. I'll get this issue updated, and get a relevant issue created in #dbt-labs/dbt-semantic-interfaces/issues |
Optional
label
attributes optional
Housekeeping
Short description
Currently different semantic layer objects treat their
label
attributes differently. Additionally on some semantic model objectslabel
isOptional
, meaning that consumers of the manifest have too look at both thename
andlabel
of a semantic layer object to determine what its "Display Name" should be.To simplify things for people writing yaml, we want to make specifying a
label
optional. Additionally we want to make life easier people consuming the manifest to only have to look in one place,label
, for a semantic layer object's "Display Name".Acceptance criteria
For the following objects
metric
,semantic_model
,saved_query
,dimension
,entity
, ormeasure
label
attribute should be optionallabel
attribute is undefined in YAML, it should be defaulted the object'sname
valueImpact to Other Teams
The semantic layer will be able to depend on the
label
attribute being presentWill backports be required?
Required? No
Context
No response
The text was updated successfully, but these errors were encountered: