Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow metric and input metric/measure filter elements to be lists as well as strings #147

Closed
3 tasks done
tlento opened this issue Sep 8, 2023 · 0 comments · Fixed by #171
Closed
3 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@tlento
Copy link
Collaborator

tlento commented Sep 8, 2023

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward change to existing dbt-semantic-interfaces functionality, rather than a Big Idea better suited to a discussion

Describe the feature

We are planning to push down predicates wherever possible, and we want to provide users with the ability to hint that predicates can be safely pushed down. The mechanism we've chosen is to allow users to specify a list of filters, where the final results will effectively apply ALL of the filter statements in the list. In this way, users can hint to us that given predicate can be pushed down by simply placing it in its own list element. See dbt-labs/metricflow#747 for details.

In order to support this for filters provided in the config (in addition to filters passed in to the where selector at query time) we need the config schema to accept either a List[str] or str type as it does today.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@tlento tlento added the enhancement New feature or request label Sep 8, 2023
@tlento tlento self-assigned this Sep 8, 2023
@tlento tlento added the Backport 0.2.latest Fix should be backported to 0.2.latest label Sep 8, 2023
@tlento tlento removed the Backport 0.2.latest Fix should be backported to 0.2.latest label Oct 10, 2023
@tlento tlento linked a pull request Oct 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant