From 961e4ab1e59c0a620def64cef39e079229f9f604 Mon Sep 17 00:00:00 2001 From: Paul Yang Date: Mon, 18 Sep 2023 14:46:10 -0700 Subject: [PATCH] Address comments. --- dbt_semantic_interfaces/implementations/saved_query.py | 2 +- .../generated_json_schemas/default_explicit_schema.json | 4 ++++ dbt_semantic_interfaces/parsing/schemas.py | 1 + dbt_semantic_interfaces/protocols/semantic_manifest.py | 6 +----- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/dbt_semantic_interfaces/implementations/saved_query.py b/dbt_semantic_interfaces/implementations/saved_query.py index b84da1f3..937b760a 100644 --- a/dbt_semantic_interfaces/implementations/saved_query.py +++ b/dbt_semantic_interfaces/implementations/saved_query.py @@ -25,7 +25,7 @@ def _implements_protocol(self) -> SavedQuery: name: str metrics: List[str] - group_bys: List[str] + group_bys: List[str] = [] where: List[PydanticWhereFilter] = [] description: Optional[str] = None diff --git a/dbt_semantic_interfaces/parsing/generated_json_schemas/default_explicit_schema.json b/dbt_semantic_interfaces/parsing/generated_json_schemas/default_explicit_schema.json index 425e7b14..8010078c 100644 --- a/dbt_semantic_interfaces/parsing/generated_json_schemas/default_explicit_schema.json +++ b/dbt_semantic_interfaces/parsing/generated_json_schemas/default_explicit_schema.json @@ -420,6 +420,10 @@ "type": "array" } }, + "required": [ + "name", + "metrics" + ], "type": "object" }, "semantic_model_defaults_schema": { diff --git a/dbt_semantic_interfaces/parsing/schemas.py b/dbt_semantic_interfaces/parsing/schemas.py index 1f83a33d..935d6617 100644 --- a/dbt_semantic_interfaces/parsing/schemas.py +++ b/dbt_semantic_interfaces/parsing/schemas.py @@ -288,6 +288,7 @@ "items": {"type": "string"}, }, }, + "required": ["name", "metrics"], "additionalProperties": False, } diff --git a/dbt_semantic_interfaces/protocols/semantic_manifest.py b/dbt_semantic_interfaces/protocols/semantic_manifest.py index 5ba6c106..0b990961 100644 --- a/dbt_semantic_interfaces/protocols/semantic_manifest.py +++ b/dbt_semantic_interfaces/protocols/semantic_manifest.py @@ -27,11 +27,7 @@ def project_configuration(self) -> ProjectConfiguration: # noqa: D @property def saved_queries(self) -> Sequence[SavedQuery]: # noqa: D - """Saved queries defined in the manifest. - - Returns a default value for backward compatibility until the next breaking release. - """ - return () + pass SemanticManifestT = TypeVar("SemanticManifestT", bound=SemanticManifest)